update test runtimes and snapshots

Cargo.toml

@@ -33,39 +33,39 @@ tokio = { version = "1.37.0" }
 zstd = { version = "0.11.2", default-features = false }
 
 # Polkadot SDK
-frame-remote-externalities = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-frame-try-runtime = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-frame-support = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
+frame-remote-externalities = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+frame-try-runtime = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+frame-support = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
 
-sc-cli = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sc-executor = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sc-service = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
+sc-cli = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sc-executor = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sc-service = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
 
-sp-api = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sp-consensus-aura = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sp-consensus-babe = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sp-core = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sp-externalities = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sp-inherents = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sp-io = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sp-keystore = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sp-rpc = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sp-runtime = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sp-state-machine = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sp-storage = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sp-std = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sp-timestamp = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sp-transaction-storage-proof = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sp-version = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-sp-weights = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
+sp-api = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sp-consensus-aura = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sp-consensus-babe = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sp-core = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sp-externalities = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sp-inherents = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sp-io = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sp-keystore = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sp-rpc = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sp-runtime = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sp-state-machine = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sp-storage = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sp-std = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sp-timestamp = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sp-transaction-storage-proof = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sp-version = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+sp-weights = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
 
-substrate-cli-test-utils = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-substrate-rpc-client = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
+substrate-cli-test-utils = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+substrate-rpc-client = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
 
-polkadot-primitives = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-cumulus-primitives-parachain-inherent = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-cumulus-primitives-core = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
-cumulus-client-parachain-inherent = { git = "https://github.com/paritytech/polkadot-sdk", branch = "liam-remote-ext-snapshot-header" }
+polkadot-primitives = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+cumulus-primitives-parachain-inherent = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+cumulus-primitives-core = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
+cumulus-client-parachain-inherent = { git = "https://github.com/paritytech/polkadot-sdk", rev = "efc2132fa2ece419d36af03c935b3c2c60440eb5" }
 
 # Local
 try-runtime-core = { path = "core" }

core/tests/runtimes/readme.md

@@ -0,0 +1,69 @@
+
+# Test Runtimes
+
+Some runtimes to use in tests.
+
+## Generation Instructions
+
+### No Migrations
+
+Just pass an empty Migrations tuple to executive.
+
+### Bad Spec Name
+
+Set the `spec_name` to something other than what's in the on-chain runtime.
+
+### Non-Incrementing Spec Version
+
+Set the `spec_version` to less than or equal to the current on-chain runtime version.
+
+### Not Idempotent Execution
+
+Add a migration that is non-idempotent. E.g.
+
+```rust
+pub struct NonIdempotentExceptionMigration;
+
+impl frame_support::traits::OnRuntimeUpgrade for NonIdempotentExceptionMigration {
+	fn on_runtime_upgrade() -> Weight {
+		let key = sp_core::blake2_128(b"some_random_seed");
+		if frame_support::storage::unhashed::get(&key[..]).unwrap_or(false) {
+			panic!("exception");
+		};
+		frame_support::storage::unhashed::put::<bool>(&key[..], &true);
+
+		<Runtime as frame_system::Config>::DbWeight::get().writes(1)
+	}
+}
+```
+
+### Not Idempotent State Root
+
+Add a migration that is non-idempotnent w.r.t the state root. E.g.
+
+```rust
+pub struct NonIdempotentStateRootMigration;
+
+impl frame_support::traits::OnRuntimeUpgrade for NonIdempotentStateRootMigration {
+	fn on_runtime_upgrade() -> Weight {
+		let key = sp_core::blake2_128(b"some_random_seed");
+		let cur = frame_support::storage::unhashed::get(&key[..]).unwrap_or(0);
+		frame_support::storage::unhashed::put::<u32>(&key[..], &(cur + 1u32));
+		<Runtime as frame_system::Config>::DbWeight::get().writes(1)
+	}
+}
+```
+
+### Weight Issue
+
+Add a migration that is overweight. E.g.
+
+```rust
+pub struct OverweightMigration;
+
+impl frame_support::traits::OnRuntimeUpgrade for OverweightMigration {
+	fn on_runtime_upgrade() -> Weight {
+		<Runtime as frame_system::Config>::BlockWeights::get().max_block
+	}
+}
+```