fix: MacOS command line app crashes if Parse framework is installed in `/Library/Frameworks/` #1395

JohnCaccavale · 2019-03-08T21:17:09Z

This PR Resolves issue #1391 where a macOS Command Line App will crash when the Parse Framework is installed in /Library/Frameworks/

…uld crash if the Parse Framework is installed in /Library/Frameworks, which results in the framework accidentally being filtered out and thus not having its subclasses properly registered.

TomWFox · 2019-03-17T17:56:43Z

Could anyone take a look at this? - @mrmarcsmith @jjmaceda @kennic

mrmarcsmith · 2019-03-17T22:46:05Z

Thanks @JohnCaccavale for this PR! I know this may be difficult given the nature of this PR but can you think of any way to write a test to ensure current and future functionality?

JohnCaccavale · 2019-03-21T03:48:38Z

Sorry, I've been very busy lately. Will try to take a look into that when I can get a chance.

ShawnBaek · 2019-03-30T06:15:59Z

I wonder who is assignees and managing this repo?

acinader · 2019-03-30T06:39:26Z

@ShawnBaek see #1356

This reverts commit 68a39d1.

parse-github-assistant · 2022-01-14T03:05:53Z

Thanks for opening this pull request!

❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

JohnCaccavale · 2022-01-14T03:10:53Z

@mtrezza I see this PR is still available. Please let me know if you would be able to review and if there's anything else that would be needed from me.

mtrezza · 2022-01-15T13:17:28Z

@mrmarcsmith could I add you to the team of Parse ObjC SDK reviewers? The group gets a notification when a PR is ready for review.

mtrezza

The only thing I can king of would be a test, if that is possible at all for this kind of change?

JohnCaccavale · 2022-01-16T03:23:19Z

Yeah, I wasn't sure about how to setup a test for this type of scenario when I originally opened up the PR either. But, this fix had addressed my issue, which I've been using in my local branch since the PR was originally opened. Quite some time now. I would be concerned if this fix broke existing tests, which currently I'm seeing one macOS test failing, but not sure if thats a flaky test or not.

Failing tests:
	ParseUnitTests-macOS:
		-[AnonymousUtilsTests testLogInViaBlock]

mtrezza · 2022-01-16T10:43:01Z

Let's see whether the test passes in rerun, but I think this is good to merge also without test which may be difficult to implement.

mtrezza · 2022-01-16T11:41:42Z

The same test keeps failing, but I noticed that it also failed before this PR, so I think we are good to merge.

mtrezza · 2022-07-26T12:57:08Z

I think we can merge this, but the carthage CI is currently failing, so we may have to address this first.

JohnCaccavale · 2022-07-29T14:20:16Z

@mtrezza Just saw your message, I'm off from work today, let me know if there's anything I can do. I see there was a recently a PR merged with regards to increasing the time out of the carthage CircleCI timeout, I'm hoping that would help address the failure being shown here.

I pulled in your latest changes with regards to that fix that was merged. The tasks are currently running, will keep an eye on that status of them.

mtrezza · 2022-07-29T21:05:28Z

I just approved the workflow to run, let's see...

parse-github-assistant · 2023-01-30T02:57:47Z

I will reformat the title to use the proper commit message syntax.

mtrezza · 2023-01-30T03:00:56Z

Carthage support has been removed, so if the CI passes, we can merge this finally

JohnCaccavale · 2023-01-30T03:03:44Z

@mtrezza great! I won't have to keep applying my patch any longer 😂. Hopefully the tests will pass. 🤞

mtrezza

Looks good! The failing macOS test is a flaky one.

Parse/Parse/Internal/Object/Subclassing/PFObjectSubclassingController.m

parse-github-assistant · 2023-01-30T11:00:20Z

I will reformat the title to use the proper commit message syntax.

## [2.0.2](2.0.1...2.0.2) (2023-01-30) ### Bug Fixes * MacOS command line app crashes if Parse framework is installed in `/Library/Frameworks/` ([#1395](#1395)) ([54bc6f3](54bc6f3))

parseplatformorg · 2023-01-30T11:23:31Z

🎉 This change has been released in version 2.0.2

JohnCaccavale added 2 commits March 8, 2019 15:24

Resolves issue parse-community#1391 where a macOS Command Line App wo…

790bb22

…uld crash if the Parse Framework is installed in /Library/Frameworks, which results in the framework accidentally being filtered out and thus not having its subclasses properly registered.

Updated bundle filtering to be more specific (parse-community#1391)

5d2d1e0

JohnCaccavale mentioned this pull request Mar 8, 2019

macOS Command Line App Crash #1391

Closed

mrmarcsmith self-requested a review March 17, 2019 22:42

acinader mentioned this pull request Mar 30, 2019

Maintainers wanted #1356

Closed

TomWFox added type:bug Impaired feature or lacking behavior that is likely assumed In Progress labels Apr 12, 2019

rodrigocarrapeiro previously approved these changes Jan 15, 2020

View reviewed changes

rodrigocarrapeiro pushed a commit to rodrigocarrapeiro/Parse-SDK-iOS-OSX that referenced this pull request Jan 15, 2020

parse-community#1395

68a39d1

rodrigocarrapeiro pushed a commit to rodrigocarrapeiro/Parse-SDK-iOS-OSX that referenced this pull request Jan 15, 2020

Revert "parse-community#1395"

abd101a

This reverts commit 68a39d1.

mtrezza removed the In Progress label Oct 14, 2021

Merge branch 'master' into macOS_command_line_app_crash

9de7e97

JohnCaccavale changed the title ~~macOS Command Line App Crash~~ fix: macOS Command Line App Crash Jan 14, 2022

mtrezza reviewed Jan 15, 2022

View reviewed changes

mtrezza removed the request for review from mrmarcsmith January 15, 2022 13:20

mtrezza requested a review from a team January 16, 2022 11:42

mtrezza changed the title ~~fix: macOS Command Line App Crash~~ fix: macOS command line app crash Jan 16, 2022

mtrezza removed the type:bug Impaired feature or lacking behavior that is likely assumed label Jan 19, 2022

Merge branch 'master' into macOS_command_line_app_crash

66713d3

Merge branch 'master' into macOS_command_line_app_crash

4a975a0

Merge branch 'master' into macOS_command_line_app_crash

c496b60

parse-github-assistant bot changed the title ~~fix: macOS command line app crash~~ fix: MacOS command line app crash Jan 30, 2023

mtrezza previously approved these changes Jan 30, 2023

View reviewed changes

Parse/Parse/Internal/Object/Subclassing/PFObjectSubclassingController.m Outdated Show resolved Hide resolved

code style

19b9ce1

mtrezza dismissed stale reviews from rodrigocarrapeiro and themself via 19b9ce1 January 30, 2023 10:58

mtrezza reviewed Jan 30, 2023

View reviewed changes

Parse/Parse/Internal/Object/Subclassing/PFObjectSubclassingController.m Show resolved Hide resolved

code style

1c80c80

mtrezza approved these changes Jan 30, 2023

View reviewed changes

mtrezza changed the title ~~fix: MacOS command line app crash~~ fix: macOS command line app crashes if Parse framework is installed in /Library/Frameworks/ Jan 30, 2023

parse-github-assistant bot changed the title ~~fix: macOS command line app crashes if Parse framework is installed in /Library/Frameworks/~~ fix: MacOS command line app crashes if Parse framework is installed in /Library/Frameworks/ Jan 30, 2023

mtrezza merged commit 54bc6f3 into parse-community:master Jan 30, 2023

parseplatformorg added the state:released Released as stable version label Jan 30, 2023

Uh oh!

fix: MacOS command line app crashes if Parse framework is installed in /Library/Frameworks/ #1395

fix: MacOS command line app crashes if Parse framework is installed in /Library/Frameworks/ #1395

Uh oh!

Conversation

JohnCaccavale commented Mar 8, 2019

Uh oh!

TomWFox commented Mar 17, 2019

Uh oh!

mrmarcsmith commented Mar 17, 2019

Uh oh!

JohnCaccavale commented Mar 21, 2019

Uh oh!

ShawnBaek commented Mar 30, 2019

Uh oh!

acinader commented Mar 30, 2019

Uh oh!

parse-github-assistant bot commented Jan 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks for opening this pull request!

Uh oh!

JohnCaccavale commented Jan 14, 2022

Uh oh!

mtrezza commented Jan 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

JohnCaccavale commented Jan 16, 2022

Uh oh!

mtrezza commented Jan 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtrezza commented Jan 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtrezza commented Jul 26, 2022

Uh oh!

JohnCaccavale commented Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtrezza commented Jul 29, 2022

Uh oh!

parse-github-assistant bot commented Jan 30, 2023

Uh oh!

mtrezza commented Jan 30, 2023

Uh oh!

JohnCaccavale commented Jan 30, 2023

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

parse-github-assistant bot commented Jan 30, 2023

Uh oh!

parseplatformorg commented Jan 30, 2023

Uh oh!

Uh oh!

fix: MacOS command line app crashes if Parse framework is installed in `/Library/Frameworks/` #1395

fix: MacOS command line app crashes if Parse framework is installed in `/Library/Frameworks/` #1395

parse-github-assistant bot commented Jan 14, 2022 •

edited

Loading

mtrezza commented Jan 15, 2022 •

edited

Loading

mtrezza commented Jan 16, 2022 •

edited

Loading

mtrezza commented Jan 16, 2022 •

edited

Loading

JohnCaccavale commented Jul 29, 2022 •

edited

Loading