fix: to-sql-date returns a java.sql.Date

Author: Vadim Platonov

CHANGELOG.md

@@ -1,3 +1,10 @@
+## 0.3.0
+
+### Fixed
+
+* *Breaking*: `to-sql-date` converts anything convertible to `LocalDate` into a `java.sql.Date`.
+  Previously `to-sql-date` worked the same as `to-java-date`.
+
 ## 0.2.2
 
 ### Fixed

src/java_time/convert.clj

@@ -1,6 +1,7 @@
 (ns java-time.convert
   (:require [java-time.core :as jt.c]
             [java-time.util :as jt.u]
+            [java-time.local :as jt.l]
             [java-time.properties :as jt.p]
             [java-time.temporal :as jt.t])
   (:import [java.time.temporal TemporalUnit ChronoUnit]
@@ -88,9 +89,12 @@
     (Date/from (jt.t/instant o))))
 
 (defn ^java.sql.Date to-sql-date
-  "Converts a date entity to a `java.sql.Date`."
-  [o]
-  (java.sql.Date/from (jt.t/instant o)))
+  "Converts a local date entity to a `java.sql.Date`.
+
+  This function only has a single arity and works for entities directly
+  convertible to `java.time.LocalDate`. Please consider using `sql-date`
+  instead."
+  [o] (java.sql.Date/valueOf (jt.l/local-date o)))
 
 (defn ^java.sql.Timestamp to-sql-timestamp
   "Converts a date entity to a `java.sql.Timestamp`."

test/java_time_test.clj

@@ -605,13 +605,17 @@
   (testing "converts through instant"
     (is (= (j/instant 1000) (j/instant (java.util.Date. 1000))))
     (is (= (java.util.Date. 1000) (j/to-java-date 1000)))
-    (is (= (java.sql.Date. 1000) (j/to-sql-date 1000)))
+    (is (= (java.sql.Date/valueOf (j/local-date 1000)) (j/to-sql-date 1000)))
     (is (= (java.sql.Timestamp. 1000) (j/to-sql-timestamp 1000)))
     (is (= 1000
            (j/to-millis-from-epoch 1000)
            (j/to-millis-from-epoch (java.util.Date. 1000))
            (j/to-millis-from-epoch (j/offset-date-time (j/instant 1000) +0)))))
 
+  (testing "converts to java.util/sql Dates"
+    (is (= (java.util.Date. 1000) (j/to-java-date (j/instant 1000))))
+    (is (= (java.sql.Date/valueOf (j/local-date 2016)) (j/to-sql-date (j/local-date 2016)))))
+
   (testing "from java.util Date types"
     (is (= (j/zone-id "UTC") (j/zone-id (java.util.TimeZone/getTimeZone "UTC"))))))