#5583 Fixed table labels on Database List to enforce the lazy-loaded table schemas to be loaded at once when this option is enabled.

Author: Paweł Salawa

ChangeLog.md

@@ -72,6 +72,7 @@
 - BUGFIX: Improved Code Assistant suggestions when SQL editor contains more than one query.
 - BUGFIX: #5089 User-defined functions now follow database renaming in case the function was explicitly registered for the database.
 - BUGFIX: #5584 Fixed user-defined collations.
+- BUGFIX: #5583 Fixed table labels on Database List to enforce the lazy-loaded table schemas to be loaded at once when this option is enabled.
 
 ### 3.4.21
 - ADDED: #5466 Support foreign keys with implicit columns (proper values in FK combobox columns).

SQLiteStudio3/guiSQLiteStudio/dbtree/dbtreemodel.cpp

@@ -38,6 +38,7 @@ DbTreeModel::DbTreeModel()
     connect(CFG, SIGNAL(massSaveBegins()), this, SLOT(massSaveBegins()));
     connect(CFG, SIGNAL(massSaveCommitted()), this, SLOT(massSaveCommitted()));
     connect(CFG_UI.DbList.ShowSystemObjects, SIGNAL(changed(QVariant)), this, SLOT(markSchemaReloadingRequired()));
+    connect(CFG_UI.DbList.ShowRegularTableLabels, SIGNAL(changed(QVariant)), this, SLOT(markSchemaReloadingRequired()));
 
     dbOrganizer = new DbObjectOrganizer(confirmReferencedTables, resolveNameConflict, confirmConversion, confirmConversionErrors);
     dbOrganizer->setAutoDelete(false);
@@ -606,6 +607,16 @@ void DbTreeModel::refreshSchema(Db* db, QStandardItem *item)
     QList<QStandardItem*> viewItems = refreshSchemaViews(views, sort);
     refreshSchemaBuild(item, tableItems, viewItems);
     populateChildItemsWithDb(item, db);
+
+    if (CFG_UI.DbList.ShowRegularTableLabels.get())
+    {
+        for (QStandardItem*& item : tableItems)
+            loadTableSchema(dynamic_cast<DbTreeItem*>(item));
+
+        for (QStandardItem*& item : viewItems)
+            loadViewSchema(dynamic_cast<DbTreeItem*>(item));
+    }
+
     restoreExpandedState(expandedState, item);
     restoreSelectionState(selectionState);
 }

SQLiteStudio3/guiSQLiteStudio/dialogs/configdialog.ui

@@ -360,7 +360,7 @@
                  <item>
                   <widget class="QCheckBox" name="regularTableLabelsCheck">
                    <property name="toolTip">
-                    <string>For regular tables labels will show number of columns, indexes and triggers for each of tables.</string>
+                    <string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;Shows number of columns, indexes and triggers next to each table name.&lt;/p&gt;&lt;p&gt;Requires loading full schema for all tables. For databases with hundreds or thousands of tables, this can significantly impact performance.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
                    </property>
                    <property name="text">
                     <string>Display labels for regular tables</string>
@@ -474,8 +474,8 @@
                <rect>
                 <x>0</x>
                 <y>0</y>
-                <width>432</width>
-                <height>731</height>
+                <width>456</width>
+                <height>754</height>
                </rect>
               </property>
               <layout class="QVBoxLayout" name="verticalLayout_34">
@@ -2330,8 +2330,8 @@
                <rect>
                 <x>0</x>
                 <y>0</y>
-                <width>366</width>
-                <height>353</height>
+                <width>389</width>
+                <height>363</height>
                </rect>
               </property>
               <layout class="QVBoxLayout" name="verticalLayout_31">
@@ -2786,7 +2786,7 @@ p, li { white-space: pre-wrap; }
 hr { height: 1px; border-width: 0; }
 li.unchecked::marker { content: &quot;\2610&quot;; }
 li.checked::marker { content: &quot;\2612&quot;; }
-&lt;/style&gt;&lt;/head&gt;&lt;body style=&quot; font-family:'Segoe UI'; font-size:9pt; font-weight:400; font-style:normal;&quot;&gt;
+&lt;/style&gt;&lt;/head&gt;&lt;body style=&quot; font-family:'Sans Serif'; font-size:9pt; font-weight:400; font-style:normal;&quot;&gt;
 &lt;p style=&quot; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;&quot;&gt;&lt;span style=&quot; font-family:'MS Shell Dlg 2'; font-size:8pt;&quot;&gt;Abcdefgh&lt;/span&gt;&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
                        </property>
                       </widget>
@@ -2877,8 +2877,8 @@ li.checked::marker { content: &quot;\2612&quot;; }
                <rect>
                 <x>0</x>
                 <y>0</y>
-                <width>224</width>
-                <height>481</height>
+                <width>235</width>
+                <height>493</height>
                </rect>
               </property>
               <layout class="QVBoxLayout" name="verticalLayout_9">