PHPCS doesn't use yoda conditions, so disallow them in the standard

Author: gsherwood

phpcs.xml.dist

@@ -60,6 +60,7 @@
     <rule ref="Squiz.WhiteSpace.SuperfluousWhitespace"/>
     <rule ref="Generic.Arrays.DisallowLongArraySyntax"/>
     <rule ref="Generic.Commenting.Todo"/>
+    <rule ref="Generic.ControlStructures.DisallowYodaConditions"/>
     <rule ref="Generic.ControlStructures.InlineControlStructure"/>
     <rule ref="Generic.Formatting.DisallowMultipleStatements"/>
     <rule ref="Generic.Formatting.SpaceAfterCast"/>

src/Files/File.php

@@ -2529,7 +2529,7 @@ public function findExtendedClassName($stackPtr)
 
         $classOpenerIndex = $this->tokens[$stackPtr]['scope_opener'];
         $extendsIndex     = $this->findNext(T_EXTENDS, $stackPtr, $classOpenerIndex);
-        if (false === $extendsIndex) {
+        if ($extendsIndex === false) {
             return false;
         }
 

src/Reporter.php

@@ -143,7 +143,7 @@ public function __construct(Config $config)
             }
 
             $reportClass = new $reportClassName();
-            if (false === ($reportClass instanceof Report)) {
+            if (($reportClass instanceof Report) === false) {
                 throw new RuntimeException('Class "'.$reportClassName.'" must implement the "PHP_CodeSniffer\Report" interface.');
             }