Merge pull request #328 from stesie/v8-6.3-fixes

stesie · web-flow · commit b9bde377ba62 · 2017-09-24T18:57:06.000+02:00
V8 6.3 fixes
diff --git a/Vagrantfile b/Vagrantfile
@@ -18,7 +18,7 @@ Vagrant.configure("2") do |config|
   #
   # mass-define "generic" Ubuntu boxes
   #
-  %w{5.7 5.8 5.9 6.0}.each { |version|
+  %w{5.7 5.8 5.9 6.0 6.3}.each { |version|
     config.vm.define "v8-#{version}" do |i|
       i.vm.synced_folder ".", "/data/v8js"
 
diff --git a/v8js_object_export.cc b/v8js_object_export.cc
@@ -664,8 +664,7 @@ v8::Local<v8::Value> v8js_named_property_callback(v8::Local<v8::String> property
 				}
 			}
 		} else if (callback_type == V8JS_PROP_QUERY) {
-			// methods are not enumerable
-			ret_value = V8JS_UINT(v8::ReadOnly|v8::DontEnum|v8::DontDelete);
+			ret_value = V8JS_UINT(v8::ReadOnly|v8::DontDelete);
 		} else if (callback_type == V8JS_PROP_SETTER) {
 			ret_value = set_value; // lie.  this field is read-only.
 		} else if (callback_type == V8JS_PROP_DELETER) {

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ Vagrant.configure("2") do \|config\|`
`18`	`18`	`#`
`19`	`19`	`# mass-define "generic" Ubuntu boxes`
`20`	`20`	`#`
`21`		`- %w{5.7 5.8 5.9 6.0}.each { \|version\|`
	`21`	`+ %w{5.7 5.8 5.9 6.0 6.3}.each { \|version\|`
`22`	`22`	`config.vm.define "v8-#{version}" do \|i\|`
`23`	`23`	`i.vm.synced_folder ".", "/data/v8js"`
`24`	`24`
Original file line number	Diff line number	Diff line change
`@@ -664,8 +664,7 @@ v8::Local<v8::Value> v8js_named_property_callback(v8::Local<v8::String> property`
`664`	`664`	`}`
`665`	`665`	`}`
`666`	`666`	`} else if (callback_type == V8JS_PROP_QUERY) {`
`667`		`- // methods are not enumerable`
`668`		`- ret_value = V8JS_UINT(v8::ReadOnly\|v8::DontEnum\|v8::DontDelete);`
	`667`	`+ ret_value = V8JS_UINT(v8::ReadOnly\|v8::DontDelete);`
`669`	`668`	`} else if (callback_type == V8JS_PROP_SETTER) {`
`670`	`669`	`ret_value = set_value; // lie. this field is read-only.`
`671`	`670`	`} else if (callback_type == V8JS_PROP_DELETER) {`