Fix caret position for Dropdown in a bottom navbar

Johann-S · Johann-S · commit a9e7abd29b79 · 2017-10-04T10:32:32.000+02:00
diff --git a/scss/_navbar.scss b/scss/_navbar.scss
@@ -75,11 +75,10 @@
     float: none;
   }
 
-  .dropup {
-    .dropdown-menu {
-      position: absolute;
-      top: auto;
-      bottom: 100%;
+  .dropdown-toggle {
+    &::after {
+      border-top: $caret-width solid;
+      border-bottom: 0;
     }
   }
 }
@@ -152,6 +151,18 @@
           padding-right: 0;
           padding-left: 0;
         }
+
+        .dropup {
+          .dropdown-menu {
+            position: absolute;
+            top: auto;
+            bottom: 100%;
+          }
+
+          .dropdown-toggle {
+            @include caret(up);
+          }
+        }
       }
 
       @include media-breakpoint-up($next) {

Original file line number	Diff line number	Diff line change
`@@ -75,11 +75,10 @@`
`75`	`75`	`float: none;`
`76`	`76`	`}`
`77`	`77`
`78`		`- .dropup {`
`79`		`- .dropdown-menu {`
`80`		`- position: absolute;`
`81`		`- top: auto;`
`82`		`- bottom: 100%;`
	`78`	`+ .dropdown-toggle {`
	`79`	`+ &::after {`
	`80`	`+ border-top: $caret-width solid;`
	`81`	`+ border-bottom: 0;`
`83`	`82`	`}`
`84`	`83`	`}`
`85`	`84`	`}`
`@@ -152,6 +151,18 @@`
`152`	`151`	`padding-right: 0;`
`153`	`152`	`padding-left: 0;`
`154`	`153`	`}`
	`154`	`+`
	`155`	`+ .dropup {`
	`156`	`+ .dropdown-menu {`
	`157`	`+ position: absolute;`
	`158`	`+ top: auto;`
	`159`	`+ bottom: 100%;`
	`160`	`+ }`
	`161`	`+`
	`162`	`+ .dropdown-toggle {`
	`163`	`+ @include caret(up);`
	`164`	`+ }`
	`165`	`+ }`
`155`	`166`	`}`
`156`	`167`
`157`	`168`	`@include media-breakpoint-up($next) {`