ドキュメントサイトに最低限の文章と画像を追加 #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsubal
commented
Mar 14, 2022
| yarn | ||
|
|
||
| ```bash | ||
| yarn add -D @charcoal/icons |
Member
Author
There was a problem hiding this comment.
icons は devDependencies 推奨ではなさそう
|
|
||
| ``` | ||
| npm i @charcoal/theme | ||
| npm i --save-dev @charcoal/theme |
fsubal
commented
Mar 14, 2022
|
|
||
| `@charcoal` is using [commintlint](https://github.com/conventional-changelog/commitlint) and | ||
| following the [Conventional Commits](https://www.conventionalcommits.org/ja/v1.0.0/) rules. | ||
| ## charcoal のはじめ方 |
Member
Author
There was a problem hiding this comment.
大文字小文字表記が揺れているのでルールがあったほうが良さそう
Contributor
There was a problem hiding this comment.
最初は大文字の気持ちでした。たしかにルール無さそう。
fsubal
commented
Mar 22, 2022
| # Charcoal | ||
|
|
||
| > Utility-first & layered design system | ||
| > Design system library by pixiv |
Comment on lines
+5
to
+7
| - ユーティリティファーストな設計 | ||
| - CSS-in-JS と CSS 両方で使える | ||
| - 既存のプロジェクトに導入がしやすい |
Member
Author
There was a problem hiding this comment.
キャッチフレーズ変更のタイミングでここを決めるので、今は一旦消す
Suggested change
| - ユーティリティファーストな設計 | |
| - CSS-in-JS と CSS 両方で使える | |
| - 既存のプロジェクトに導入がしやすい |
pnlybubbles
approved these changes
Mar 22, 2022
| ## charcoal という名前 | ||
|
|
||
| ## Setup | ||
| 「charcoal（木炭）」とはデッサンの道具であり、線を引く、表現の基礎となる素材の一つです。また創作物を主役とするサービスの基盤として、それ自体は色を持たないモノクロの素材である、というニュアンスも含みます。 |
Contributor
There was a problem hiding this comment.
めちゃよいですね。ここでコンセプトの説明がされていればリード文でコンセプトについて触れなくてもよいかもしれない。
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
ドキュメントサイトにコンテンツを加えた
バージョニング
{+ 破壊的変更なし +} / {- 破壊的変更あり -}
チェックリスト
不要なチェック項目は消して構いません