fixed 'play idea' now is correctly for WSL Run GitHub Action on win and fixed test for Windows #1382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacol84
changed the title
add workflows with windows and JDK 17 for tests
Contributor
Author
|
now you can run IDEA from WSL |
jacol84
changed the title
xael-fry
approved these changes
Mar 13, 2022
xabolcs
reviewed
Apr 4, 2022
| shutil.copyfile(os.path.join(play_env["basedir"], 'resources/idea/imlTemplate.xml'), imlFile) | ||
| cpXML = "" | ||
|
|
||
| playHome = play_env["basedir"].replace('\\', '/') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Helpful things
Fixes
#1371
#1366
#1292
added ability to run IDEA with WSL
fixed test on Windows play.templates.FastTagsTest
Purpose
now you can run IDEA from WSL
fixes the test that screams
end of line problem in jdk 11 and 17 under Windows and system variable "line.separator"
System.setProperty("line.separator","\n");Background Context
I solved the problem by inserting line breaks as they are in the system and now it will not test depend on OS
I added "action "it to the tests performed on OS-Windows and jdk17 so that this situation would not happen
added run