Skip to content

Commit f23e4cb

Browse files
committed
move important info on making baselines and remove fat docker readme
1 parent ff9b12f commit f23e4cb

File tree

2 files changed

+8
-222
lines changed

2 files changed

+8
-222
lines changed

CONTRIBUTING.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,14 @@ python3 -m pip install kaleido
220220
python3 -m pip install plotly
221221
```
222222

223+
**IMPORTANT:** the `baseline`, `test-image` and `test-export` scripts do **not** bundle the source files before
224+
running the image tests. We recommend running `npm run watch` or `npm start` in
225+
a separate tab to ensure that the most up-to-date code is used.
226+
Also if you are adding a new mock, you may need to re-run `npm start` or `npm run watch`
227+
to be able to find the new mock in the browser.
228+
To help ensure valid attributes are used in your new mock(s), please run `npm run test-mock`
229+
or `npm run test-mock mock_name(s)` after adding new mocks or implementing any new attributes.
230+
223231
If you added new mocks to test/image/mocks folder, to generate draft baselines run
224232
```sh
225233
python3 test/image/make_baseline.py = mockFilename1 mockFilename2

test/image/README.md

Lines changed: 0 additions & 222 deletions
This file was deleted.

0 commit comments

Comments
 (0)