Skip to content

Conversation

@exussum12
Copy link
Collaborator

relates to #361. Added some tests. All passing on Chrome and Firefox, Not tested others

@philfreo
Copy link
Collaborator

philfreo commented May 7, 2014

@exussum12 can you see if list.js (in extra/) needs a similar update? There are some other PRs (e.g. #372) doing similar things and it'd be nice to take care of all these setValue changes at once if they're necessary.

@exussum12
Copy link
Collaborator Author

Listy looks ok to me, All of its set values seem to update the model too

@exussum12 exussum12 closed this Sep 16, 2014
@exussum12 exussum12 deleted the updateObjects branch September 16, 2014 11:10
@Blasz
Copy link

Blasz commented Apr 16, 2015

So this PR was never landed?

@exussum12
Copy link
Collaborator Author

No. Sorry I accidently deleted the branch and then re opened the pull request. I've been using the code here for about a year and as far as I can sss its ok

@exussum12
Copy link
Collaborator Author

Oops didn't re open. I will re open after I push the branch

@exussum12 exussum12 restored the updateObjects branch April 16, 2015 08:46
@exussum12 exussum12 reopened this Apr 16, 2015
@exussum12
Copy link
Collaborator Author

Branch is back

powmedia added a commit that referenced this pull request Apr 16, 2015
Make sure render can be called after a value has been updated
@powmedia powmedia merged commit 24f4e18 into powmedia:master Apr 16, 2015
@powmedia
Copy link
Owner

Thanks @exussum12

@Blasz
Copy link

Blasz commented Apr 16, 2015

Awesome.

@fonji
Copy link
Contributor

fonji commented Apr 16, 2015

👍

@Blasz
Copy link

Blasz commented Apr 17, 2015

What's the policy on when the distribution folders should be updated. Only on tagged version releases or should they be rebuilt with/after pull requests as well?

@philfreo
Copy link
Collaborator

Just update src here -- distribution will get auto-built once it's merged in. I haven't had a chance to look at this yet but maybe @powmedia has.

@exussum12 does the test I wrote in #378 (comment) pass in this branch?

@exussum12 exussum12 deleted the updateObjects branch October 1, 2015 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants