Merge pull request #36161 from peppy/editor-no-smooth-seeking

Change editor to not seek smoothly when performing distant seeks

Author: bdach

osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/MarkerPart.cs

@@ -70,7 +70,7 @@ private void seekToPosition(Vector2 screenPosition, bool instant)
             if (editorClock.IsRunning && !instant && lastSeekTime != null && Time.Current - lastSeekTime < NowPlayingOverlay.TRACK_DRAG_SEEK_DEBOUNCE)
                 return;
 
-            editorClock.SeekSmoothlyTo(seekDestination);
+            editorClock.Seek(seekDestination);
 
             lastSeekTime = instant ? null : Time.Current;
         }

osu.Game/Screens/Edit/EditorClock.cs

@@ -209,20 +209,25 @@ public bool Seek(double position)
         }
 
         /// <summary>
-        /// Seek smoothly to the provided destination.
+        /// Seek smoothly to the provided destination, if within a certain proximity to the current viewport.
         /// Use <see cref="Seek"/> to perform an immediate seek.
         /// </summary>
         /// <param name="seekDestination"></param>
         public void SeekSmoothlyTo(double seekDestination)
         {
             seekingOrStopped.Value = true;
 
-            if (IsRunning)
-                Seek(seekDestination);
-            else
+            // The whole point of seeking smoothly is to maintain continuity for the user.
+            // Above a certain proximity, there's little reason to do this as the jump is already huge.
+            const double smooth_seek_max_proximity = 5000;
+
+            if (IsRunning || Math.Abs(seekDestination - currentTime) > smooth_seek_max_proximity)
             {
-                transformSeekTo(seekDestination, transform_time, Easing.OutQuint);
+                Seek(seekDestination);
+                return;
             }
+
+            transformSeekTo(seekDestination, transform_time, Easing.OutQuint);
         }
 
         public void BindAdjustments() => track.Value?.BindAdjustments(AudioAdjustments);