Completely deny array as parameter, add more cov test

src/useFirebaseConnect.js

@@ -18,7 +18,7 @@ import useFirebase from './useFirebase'
  * // create firebase connect that uses another redux store
  * const useFirebaseConnect = createUseFirebaseConnect()
  */
-export const createUseFirebaseConnect = () => (dataOrFn = []) => {
+export const createUseFirebaseConnect = () => dataOrFn => {
   const firebase = useFirebase()
 
   const inputAsFunc = createCallable(dataOrFn)
@@ -31,12 +31,7 @@ export const createUseFirebaseConnect = () => (dataOrFn = []) => {
         return null
       }
       if (isArray(data)) {
-        if (data.length > 1) {
-          throw new Error(
-            "Array of multiple paths isn't allowed inside useFirebaseConnect hook."
-          )
-        }
-        return getEventsFromInput(data)
+        throw new Error("Array isn't allowed inside useFirebaseConnect hook.")
       }
       return getEventsFromInput([data])
     },

src/useFirestoreConnect.js

@@ -19,7 +19,7 @@ import useFirestore from './useFirestore'
  *
  * export default useFirestoreConnect()
  */
-export const createUseFirestoreConnect = () => (dataOrFn = []) => {
+export const createUseFirestoreConnect = () => dataOrFn => {
   const firestore = useFirestore()
 
   const inputAsFunc = createCallable(dataOrFn)
@@ -32,12 +32,7 @@ export const createUseFirestoreConnect = () => (dataOrFn = []) => {
         return null
       }
       if (isArray(data)) {
-        if (data.length > 1) {
-          throw new Error(
-            "Array of multiple query isn't allowed inside useFirestoreConnect hook."
-          )
-        }
-        return data
+        throw new Error("Array isn't allowed inside useFirestoreConnect hook.")
       }
       return [data]
     },

test/unit/useFirebaseConnect.spec.js

@@ -2,7 +2,12 @@ import React, { Component } from 'react'
 import ReactDOM from 'react-dom'
 import TestUtils from 'react-dom/test-utils'
 import { some, isMatch, filter } from 'lodash'
-import { storeWithFirebase, firebaseWithConfig, sleep } from '../utils'
+import {
+  ErrorBoundary,
+  storeWithFirebase,
+  firebaseWithConfig,
+  sleep
+} from '../utils'
 import useFirebaseConnect, {
   createUseFirebaseConnect
 } from '../../src/useFirebaseConnect'
@@ -16,7 +21,11 @@ function TestComponent({ dynamicProps }) {
 }
 /* eslint-enable react/prop-types */
 
-const createContainer = (additionalWrappedProps, listeners) => {
+const createContainer = ({
+  additionalComponentProps,
+  listeners,
+  component = TestComponent
+} = {}) => {
   const firebase = firebaseWithConfig()
   const store = storeWithFirebase()
   sinon.spy(store, 'dispatch')
@@ -25,17 +34,20 @@ const createContainer = (additionalWrappedProps, listeners) => {
     state = { test: 'testing', dynamic: 'start' }
 
     render() {
+      const InnerComponent = component
       return (
         <ReactReduxFirebaseProvider
           dispatch={store.dispatch}
           firebase={firebase}
           createFirestoreInstance={createFirestoreInstance}
           config={{}}>
-          <TestComponent
-            dynamicProps={this.state.dynamic}
-            testProps={this.state.test}
-            {...additionalWrappedProps}
-          />
+          <ErrorBoundary>
+            <InnerComponent
+              dynamicProps={this.state.dynamic}
+              testProps={this.state.test}
+              {...additionalComponentProps}
+            />
+          </ErrorBoundary>
         </ReactReduxFirebaseProvider>
       )
     }
@@ -131,6 +143,17 @@ describe('useFirebaseConnect', () => {
       )
     ).to.have.lengthOf(1)
   })
+
+  it('should not accept array', async () => {
+    const useFirebaseConnectSpy = sinon.spy(useFirebaseConnect)
+    const Component = () => {
+      useFirebaseConnectSpy(['test'])
+      return <div />
+    }
+    createContainer({ component: Component })
+    await sleep()
+    expect(useFirebaseConnectSpy.threw()).to.be.true
+  })
 })
 
 describe('createUseFirebaseConnect', () => {

test/unit/useFirestoreConnect.spec.js

@@ -2,7 +2,12 @@ import React, { Component } from 'react'
 import ReactDOM from 'react-dom'
 import TestUtils from 'react-dom/test-utils'
 import { some, isMatch, filter } from 'lodash'
-import { storeWithFirestore, firebaseWithConfig, sleep } from '../utils'
+import {
+  ErrorBoundary,
+  storeWithFirestore,
+  firebaseWithConfig,
+  sleep
+} from '../utils'
 import useFirestoreConnect, {
   createUseFirestoreConnect
 } from '../../src/useFirestoreConnect'
@@ -20,7 +25,11 @@ function TestComponent({ dynamicProps }) {
 }
 /* eslint-enable react/prop-types */
 
-const createContainer = (additionalWrappedProps, listeners) => {
+const createContainer = ({
+  additionalComponentProps,
+  listeners,
+  component = TestComponent
+} = {}) => {
   const firebase = firebaseWithConfig()
   const store = storeWithFirestore()
   sinon.spy(store, 'dispatch')
@@ -29,17 +38,20 @@ const createContainer = (additionalWrappedProps, listeners) => {
     state = { test: 'testing', dynamic: '' }
 
     render() {
+      const InnerComponent = component
       return (
         <ReactReduxFirebaseProvider
           dispatch={store.dispatch}
           firebase={firebase}
           createFirestoreInstance={createFirestoreInstance}
           config={{}}>
-          <TestComponent
-            dynamicProps={this.state.dynamic}
-            testProps={this.state.test}
-            {...additionalWrappedProps}
-          />
+          <ErrorBoundary>
+            <InnerComponent
+              dynamicProps={this.state.dynamic}
+              testProps={this.state.test}
+              {...additionalComponentProps}
+            />
+          </ErrorBoundary>
         </ReactReduxFirebaseProvider>
       )
     }
@@ -139,6 +151,17 @@ describe('firestoreConnect', () => {
       )
     ).to.have.lengthOf(1)
   })
+
+  it('should not accept array', async () => {
+    const useFirestoreConnectSpy = sinon.spy(useFirestoreConnect)
+    const Component = () => {
+      useFirestoreConnectSpy(['test'])
+      return <div />
+    }
+    createContainer({ component: Component })
+    await sleep()
+    expect(useFirestoreConnectSpy.threw()).to.be.true
+  })
 })
 
 describe('createUseFirestoreConnect', () => {

test/utils.js

@@ -25,6 +25,31 @@ export class Container extends Component {
   }
 }
 
+export class ErrorBoundary extends Component {
+  constructor(props) {
+    super(props)
+    this.state = { hasError: false }
+  }
+
+  static getDerivedStateFromError(error) {
+    // Update state so the next render will show the fallback UI.
+    return { hasError: true, error }
+  }
+
+  render() {
+    if (this.state.hasError) {
+      // You can render any custom fallback UI
+      return <h1>Something went wrong.</h1>
+    }
+
+    return this.props.children
+  }
+}
+
+ErrorBoundary.propTypes = {
+  children: PropTypes.node.isRequired
+}
+
 export class ProviderMock extends Component {
   getChildContext() {
     return { store: this.props.store }