-
-
Notifications
You must be signed in to change notification settings - Fork 208
Merge with eslint-plugin-prettify #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3e983f1
Chore: Use eslint-plugin-prettier without symlink
zertosh bb912f4
Chore: Lint .eslintrc.js via CLI automatically
zertosh e313bdd
Chore: Update remaining repo links
zertosh 3d757e6
New: Replace implementation with line-by-line reporting (fixes #17)
zertosh 8d9b6e7
Fix: Use non-global line ending regex
zertosh 484da18
Fix: Use unicode literals instead of escapes in showInvisibles
zertosh f58b054
Fix: Use documented range form when calling insertTextAfterRange
zertosh a0c8a0e
Fix: Un-shebang test file
zertosh 7ba59f6
Fix: ESLint 4.x compat (handle shebangs and no deprecated APIs)
zertosh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Fix: ESLint 4.x compat (handle shebangs and no deprecated APIs)
- Loading branch information
commit 7ba59f61992135f57a855f061f17946cfe9549fa
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| CODE: | ||
| #!/usr/bin/env node | ||
| /** @format */ | ||
| var foo = ''; | ||
|
|
||
| OUTPUT: | ||
| #!/usr/bin/env node | ||
| /** @format */ | ||
| var foo = ""; | ||
|
|
||
| OPTIONS: | ||
| [null, '@format'] | ||
|
|
||
| ERRORS: | ||
| [ | ||
| { | ||
| message: 'Replace `\'\'` with `""`', | ||
| line: 3, column: 11, endLine: 3, endColumn: 13, | ||
| }, | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a strong objection, but I have doubts about whether putting the invalid cases in separate files actually improves debuggability. If a single test case is failing, it seems like it would be easier to search for the corresponding code within a single file rather than opening/closing a bunch of test files to try to find the right one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it's actually more about easily looking at a fixture file and easily converting line & column in the test vs the message. It's also very convenient to be able to quickly focus on a few tests by commenting out.