-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Adds geometry to downloadable obj files functionality #6812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b211f73
Adds geometry to downloadable obj files functionality
diyaayay 778bc40
changes function name to saveObj
diyaayay 2578053
using downloadFile instead of save and added documentation
diyaayay 5773158
unit test and minor fix
diyaayay 0a9cf53
Update p5.Geometry.js
dgrantham01 003af34
Merge branch 'main' into Downloadable-obj-file
davepagurek 6302061
Update documentation, fix typos
davepagurek 5b915f1
Add describe()
davepagurek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| suite('saveModel',function() { | ||
| var myp5; | ||
| setup(function(done) { | ||
| new p5(function(p) { | ||
| p.setup = function() { | ||
| myp5 = p; | ||
| done(); | ||
| }; | ||
| }); | ||
| }); | ||
| teardown(function() { | ||
| myp5.remove(); | ||
| }); | ||
| testWithDownload( | ||
| 'should download an .obj file with expected contents', | ||
| async function(blobContainer) { | ||
| //.obj content as a string | ||
| const objContent = `v 100 0 0 | ||
| v 0 -100 0 | ||
| v 0 0 -100 | ||
| v 0 100 0 | ||
| v 100 0 0 | ||
| v 0 0 -100 | ||
| v 0 100 0 | ||
| v 0 0 100 | ||
| v 100 0 0 | ||
| v 0 100 0 | ||
| v 0 0 -100 | ||
| v -100 0 0 | ||
| v -100 0 0 | ||
| v 0 -100 0 | ||
| v 0 0 100 | ||
| v 0 0 -100 | ||
| v 0 -100 0 | ||
| v -100 0 0 | ||
| v 0 100 0 | ||
| v -100 0 0 | ||
| v 0 0 100 | ||
| v 0 0 100 | ||
| v 0 -100 0 | ||
| v 100 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vt 0 0 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| vn 0 0 1 | ||
| f 1 2 3 | ||
| f 4 5 6 | ||
| f 7 8 9 | ||
| f 10 11 12 | ||
| f 13 14 15 | ||
| f 16 17 18 | ||
| f 19 20 21 | ||
| f 22 23 24 | ||
| `; | ||
|
|
||
| const objBlob = new Blob([objContent], { type: 'text/plain' }); | ||
|
|
||
| myp5.downloadFile(objBlob, 'model', 'obj'); | ||
|
|
||
| let myBlob = blobContainer.blob; | ||
|
|
||
| let text = await myBlob.text(); | ||
|
|
||
| assert.strictEqual(text, objContent); | ||
| }, | ||
| true | ||
| ); | ||
|
|
||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this method, nice and concise!