Skip to content

Fix for gif not animating when drawing to p5.graphics #6935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Fix for gif not animating when drawing to p5.graphics #6935

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0434f4
Modified p5.Image.js to include a fallback incase
kaiserarg Mar 27, 2024
249174f
Merge branch 'processing:main' into gifongraphicanimationfix
kaiserarg Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Modified p5.Image.js to include a fallback incase 
pInst._lastRealFrameTime; does not exist. Fixes
gif animation on graphic issue.
  • Loading branch information
@kaiserarg
kaiserarg committed Mar 27, 2024
commit d0434f4d4f679b58efb565aaadb618b4395948f9
2 changes: 1 addition & 1 deletion src/image/p5.Image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ p5.Image = class {
*/
_animateGif(pInst) {
const props = this.gifProperties;
const curTime = pInst._lastRealFrameTime;
const curTime = pInst._lastRealFrameTime || window.performance.now();
Copy link
Contributor

@davepagurek davepagurek Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. At first I was worried that this wouldn't be as robust as grabbing the time from the main canvas, but there's also the chance that the graphic is being used for fully offscreen rendering and the main canvas never updates, so this is probably the best compromise for now. We can always revisit this later, I'll merge this PR!

if (props.lastChangeTime === 0) {
props.lastChangeTime = curTime;
}
Expand Down