Fix #7049: P5.Graphics.remove() doesn't release all related resources #7060
Conversation
… resources The proposed fix involves modifying the p5.Graphics.remove() method by setting this._renderer, this.canvas, and this.elt to undefined. Additionally, a boolean flag doubleClickedBool is introduced to prevent the execution of the draw() function after a double-click event ensuring that the graphics object is not displayed again after removal This provides a smoother user experience by preventing the graphics object from reappearing unexpectedly.
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
src/core/p5.Graphics.js
Outdated
| * // the user double-clicks. | ||
| * function doubleClicked() { | ||
| * pg.remove(); | ||
| * doubleClickedBool = true; |
There was a problem hiding this comment.
Rather than introducing a new variable here, could we instead do something like this?
| * doubleClickedBool = true; | |
| * pg = undefined; |
That way, we can continue to use the previous if (pg) condition. Your changes make it so setting this to undefined isn't necessary for the bulk of the content to get GCed, but it's probably a good habit to get users into doing.
There was a problem hiding this comment.
Thanks for the suggestion! I'll implement that change right away.
|
Thanks for making this change and adding tests! Just one minor note about the example. |
davepagurek
left a comment
davepagurek
left a comment
There was a problem hiding this comment.
Looks great, thanks!
|
@all-contributors please add @iambiancafonseca for docs |
|
I've put up a pull request to add @iambiancafonseca! 🎉 |
2 participants
Resolves #7049
Changes:
Now when we call remove() all associated resources should be released.
Screenshots of the change:
(no screenshots)
PR Checklist
npm run lintpasses