Corrects the circle() description #7110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clarifies that each point on the edge of the circle is half its diameter
nickmcintyre
suggested changes
Jul 3, 2024
src/core/shape/2d_primitives.js
Outdated
| * its position. | ||
| * A circle is a round shape defined by the `x`, `y`, and `d` parameters. | ||
| * `x` and `y` set the location of its center. `d` sets its width and height (diameter). | ||
| * Every point on the circle's edge is half the distance, `d`, from its center (radius = diameter/2). |
Member
There was a problem hiding this comment.
Good catch @JulioGitLab! What do you think about the following?
Every point on the circle's edge is the same distance,
0.5 * d, from its center.0.5 * d(half the diameter) is the circle's radius.
Contributor
Author
There was a problem hiding this comment.
Thanks @nickmcintyre! I think your way of explaining it is easier to understand. Let's use it!
The description of circle() was updated to one that is easier to understand
Contributor
|
Thank you both! @JulioGitLab @nickmcintyre |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This clarifies that each point on the edge of the circle is half its diameter.
PR Checklist
npm run lintpasses