Added window size check upon p5 instantiation #7134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where `windowWidth` and `windowHeight` would represent the correct values when the window was resized and no p5 sketch was active
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
davepagurek
approved these changes
Jul 18, 2024
Contributor
davepagurek
left a comment
davepagurek
left a comment
There was a problem hiding this comment.
Thanks for helping narrow down the cause of this bug!
davepagurek
requested changes
Jul 18, 2024
Contributor
Author
|
I've just updated where the function is called to run before the init handlers as you suggested |
davepagurek
approved these changes
Jul 19, 2024
Contributor
davepagurek
left a comment
davepagurek
left a comment
There was a problem hiding this comment.
Thanks for making those changes, looks great!
Contributor
|
@all-contributors please add @Evorage0 for bug, code |
Contributor
|
I've put up a pull request to add @Evorage0! 🎉 |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7133
Changes:
Adds a function called upon p5 initialisation which fixes a bug where
windowWidthandwindowHeightwould represent the correct values when the window was resized and no p5 sketch was activeVideo of the before:
https://github.com/user-attachments/assets/82ebad21-5d55-4203-870b-184f9b8775e8
PR Checklist
npm run lintpasses