Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup to mark fields private
  • Loading branch information
mkruskal-google committed May 9, 2025
commit 7edfcab770d8360547a06c7f4064f6eda8d9b040
15 changes: 0 additions & 15 deletions index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -903,21 +903,6 @@ export abstract class ReflectionObject {
/** Unique name within its namespace. */
public name: string;

/** The edition specified for this object. Only relevant for top-level objects. */
public _edition: string;

/**
* The default edition to use for this object if none is specified. For legacy reasons,
* this is proto2 except in the JSON parsing case where it was proto3.
*/
public _defaultEdition: string;

/** Resolved Features. */
public _features: object;

/** Whether or not features have been resolved. */
public _featuresResolved: boolean;

/** Parent namespace. */
public parent: (Namespace|null);

Expand Down
4 changes: 4 additions & 0 deletions src/object.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,25 +51,29 @@ function ReflectionObject(name, options) {
/**
* The edition specified for this object. Only relevant for top-level objects.
* @type {string}
* @private
*/
this._edition = null;

/**
* The default edition to use for this object if none is specified. For legacy reasons,
* this is proto2 except in the JSON parsing case where it was proto3.
* @type {string}
* @private
*/
this._defaultEdition = "proto2";

/**
* Resolved Features.
* @type {object}
* @private
*/
this._features = {};

/**
* Whether or not features have been resolved.
* @type {boolean}
* @private
*/
this._featuresResolved = false;

Expand Down
6 changes: 5 additions & 1 deletion src/root.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,11 @@ function Root(options) {
*/
this.files = [];

// Default to proto2 if unspecified.
/**
* Edition, defaults to proto2 if unspecified.
* @type {string}
* @private
*/
this._edition = "proto2";
}

Expand Down