(PUP-6992) Fix inconsistent autoload of environment puppet functions #5455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Specifications needs an update. Would like to see that change first. Also, tests AppVeyor are failing atm. |
Contributor
|
Ping @puppetlabs/puppet-maintainers note the unrelated error from AppVeyor - is that a known issue? |
thallgren
force-pushed
the
issue/pup-6992/consistent-autoloads
branch
from
f669c80 to
f4d0fb3
Compare
This commit changes the autoload behavior for puppet functions and types that reside under the 'functions' or 'types' directory in an environment so that the naming becomes consistent with the ruby functions that reside under 'lib/puppet/functions'. In essence, the namespace 'environment' is moved into a subdirectory with the same name that functions and types in the global namespace can reside directly under their respective 'functions' and 'types' directory.
thallgren
force-pushed
the
issue/pup-6992/consistent-autoloads
branch
from
f4d0fb3 to
dcad982
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the autoload behavior for puppet functions and types
that reside under the 'functions' or 'types' directory in an environment
so that the naming becomes consistent with the ruby functions that
reside under 'lib/puppet/functions'.
In essence, the namespace 'environment' is moved into a subdirectory with
the same name that functions and types in the global namespace can reside
directly under their respective 'functions' and 'types' directory.