Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cirrax/puppetlabs-postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: puppetlabs/puppetlabs-postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 10 files changed
  • 7 contributors

Commits on May 29, 2025

  1. Configuration menu
    Copy the full SHA
    651c2b4 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2025

  1. Configuration menu
    Copy the full SHA
    0c6f4f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2025

  1. Allow puppetlabs/apt 11.x

    kenyon authored Sep 12, 2025
    Configuration menu
    Copy the full SHA
    79c7c0a View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2025

  1. puppet/systemd: Allow 9.x

    bastelfreak committed Sep 30, 2025
    Configuration menu
    Copy the full SHA
    9189e81 View commit details
    Browse the repository at this point in the history
  2. Debian 11: Use correct package name for python bindings

    Since Debian 11 was added to this module, the package name was wrong. It
    was set to python-psycopg2, but the correct name is python3-psycopg2.
    
    There's a longer analysis about this bug in https://github.com/puppetlabs/puppetlabs-postgresql/pull/1638/files#r2390588710
    
    tl;dr:
    
    * Debian 10 used python-psycopg2 and that was set by the module
    * Debian 11 was added without proper acceptance testing
    * Later on unit tests were added for Debian 11, but still with the wrong
      package name
    * 651c2b4 fixed the package name, but
      in the wrong place and didn't adjust the tests
    * That resulted in a broken pipeline, that's how I found all of this
    
    This patch:
    * Cleans up the hiera data
    * sets the package name at the correct location
    * adjusts the debian 11 unit test for the new package name
    * Adds tests for Debian 12 and 13 (won't be executed right now because
      Perforce ships a too old version of FacterDB)
    
    Edit: Had to remove Debian 13 because the pipeline fails if it cannot
    find a factset.
    bastelfreak committed Sep 30, 2025
    Configuration menu
    Copy the full SHA
    45d8a9d View commit details
    Browse the repository at this point in the history
  3. Merge pull request puppetlabs#1647 from bastelfreak/debian11

    Debian 11: Use correct package name for python bindings
    bastelfreak authored Sep 30, 2025
    Configuration menu
    Copy the full SHA
    b85be45 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2025

  1. Release prep v10.6.0

    GitHub Actions committed Oct 13, 2025
    Configuration menu
    Copy the full SHA
    fe40cd3 View commit details
    Browse the repository at this point in the history
  2. Merge pull request puppetlabs#1649 from puppetlabs/release-prep

    Release prep v10.6.0
    bastelfreak authored Oct 13, 2025
    Configuration menu
    Copy the full SHA
    20704ff View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2025

  1. Don't use type alias in postgresql_password

    Type aliases from modules aren't available on the agent.
    See https://puppet.atlassian.net/browse/PUP-7197
    
    This means that calls to `postgresql::postgresql_password` can't be
    deferred if the `hash` parameter uses the type
    `Postgresql::Pg_password_encryption`. Instead we have to use the raw
    `Enum`, (which unfortunately causes code duplication, but this is
    unavoidable).
    
    Using this function with `Deferred` is not just a theoretical use-case.
    The module itself tries to here.
    https://github.com/puppetlabs/puppetlabs-postgresql/blob/20704ffae24dcf970784697b1798c09d026fb7f8/manifests/server/role.pp#L162
    figless authored and alexjfisher committed Oct 23, 2025
    Configuration menu
    Copy the full SHA
    e57da89 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2025

  1. Merge pull request puppetlabs#1611 from figless/enum_postgresql_password

    Don't use type alias in `postgresql_password` parameter
    alexjfisher authored Oct 29, 2025
    Configuration menu
    Copy the full SHA
    029754c View commit details
    Browse the repository at this point in the history
Loading