Skip to content

Conversation

@gavindidrichsen
Copy link

@gavindidrichsen gavindidrichsen commented Jun 25, 2024

Summary

As a devx developer I want to publish GH Pages for several repositories. The gh pages documentation is detailed. The following key points contributed to my decision to add this change:

  • Currently there a 2 ways to generate GH Pages on a repository. The documentation calls these "sources". One is a manual push; the other uses a special github action deployment workflow.
  • After June 2024, only the github action source will be used.
  • Best practice around documentation is that (1) a special github "environment" should be created called "github-pages" and (2) a unique branch "gh-pages" should be created alongside the "main". The environment is a set of rules that limits documentation deployments from specific branches and the unique branch means that "code" and site-documentation are kept separate.

Therefore, I created the github-pages environment, the gh-pages branch, and the github action workflow defined in this PR

@codecov
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.80%. Comparing base (25ffa25) to head (c6fc857).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   86.80%   86.80%           
=======================================
  Files          35       35           
  Lines        2092     2092           
=======================================
  Hits         1816     1816           
  Misses        276      276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gavindidrichsen gavindidrichsen marked this pull request as ready for review June 26, 2024 08:58
@gavindidrichsen gavindidrichsen requested review from a team and bastelfreak as code owners June 26, 2024 08:58
As a devx developer I want to publish GH Pages for several repositories.  The [gh pages documentation](https://docs.github.com/en/pages/getting-started-with-github-pages/about-github-pages) is detailed.  The following key points contributed to my decision to add this change:
* Currently there a 2 ways to generate GH Pages on a repository.  The documentation calls these "sources".  One is a manual push; the other uses a special github action deployment workflow.
* After June 2024, only the github action source will be used.
* Best practice around documentation is that (1) a special github "environment" should be created called "github-pages" and (2) a unique branch "gh-pages" should be created alongside the "main".  The environment is a set of rules that limits documentation deployments from specific branches and the unique branch means that "code" and site-documentation are kept separate.

Therefore, I created the github-pages environment, the gh-pages branch, and the github action workflow defined in this PR
@david22swan david22swan merged commit cbda6ed into main Jun 26, 2024
@david22swan david22swan deleted the cat_1930_gh_pages branch June 26, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants