Skip to content

Add fromJson and toJson #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomashoneyman merged 4 commits into from
Jun 23, 2022
Merged

Add fromJson and toJson #109

thomashoneyman merged 4 commits into from
Jun 23, 2022

Conversation

@sigma-andex
Copy link
Contributor

@sigma-andex sigma-andex commented Jun 13, 2022

Description of the change
Add fromJson and toJson methods to simplify deserialising/serialising.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@sigma-andex sigma-andex changed the title Add parse and decode Add fromJson and toJson Jun 13, 2022
@sigma-andex sigma-andex mentioned this pull request Jun 13, 2022
Closed
@sigma-andex
Copy link
Contributor Author

sigma-andex commented Jun 17, 2022

🏓 @thomashoneyman

@sigma-andex
Copy link
Contributor Author

sigma-andex commented Jun 23, 2022

🐧 @thomashoneyman

@thomashoneyman
Copy link
Contributor

thomashoneyman commented Jun 23, 2022

What do you think of naming these “toJsonString” and “fromJsonString” given they aren’t going to and from the Json type?

@thomashoneyman
Copy link
Contributor

thomashoneyman commented Jun 23, 2022

Also, could you add this change to the changelog?

@thomashoneyman thomashoneyman merged commit 88086c6 into purescript-contrib:main Jun 23, 2022
@sigma-andex sigma-andex deleted the add-parse-and-decode branch June 23, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sigma-andex @thomashoneyman