From 698f940a61be6554870aca10f3105fa3f666415b Mon Sep 17 00:00:00 2001 From: Brian Rutledge Date: Sun, 8 May 2022 09:31:37 -0400 Subject: [PATCH 1/4] Use twine logger to ensure main always logs --- twine/__main__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/twine/__main__.py b/twine/__main__.py index 493ffb1c..322794f1 100644 --- a/twine/__main__.py +++ b/twine/__main__.py @@ -22,7 +22,7 @@ from twine import cli from twine import exceptions -logger = logging.getLogger(__name__) +logger = logging.getLogger("twine") def main() -> Any: From a49fe51f0f80cb9f0dd3bc9bb78da4a6feae0092 Mon Sep 17 00:00:00 2001 From: Brian Rutledge Date: Sun, 8 May 2022 09:37:12 -0400 Subject: [PATCH 2/4] Revert "Use twine logger to ensure main always logs" This reverts commit 698f940a61be6554870aca10f3105fa3f666415b. --- twine/__main__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/twine/__main__.py b/twine/__main__.py index 322794f1..493ffb1c 100644 --- a/twine/__main__.py +++ b/twine/__main__.py @@ -22,7 +22,7 @@ from twine import cli from twine import exceptions -logger = logging.getLogger("twine") +logger = logging.getLogger(__name__) def main() -> Any: From faa1bdb567482bbc4a255d826e7527d52e927c6b Mon Sep 17 00:00:00 2001 From: Brian Rutledge Date: Sun, 8 May 2022 09:38:34 -0400 Subject: [PATCH 3/4] Configure root logger instead of twine logger --- twine/cli.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/twine/cli.py b/twine/cli.py index efcf97c4..48f14503 100644 --- a/twine/cli.py +++ b/twine/cli.py @@ -52,6 +52,7 @@ def configure_output() -> None: # test_main.py due to capsys not being cleared. logging.config.dictConfig( { + "disable_existing_loggers": False, "version": 1, "handlers": { "console": { @@ -61,10 +62,8 @@ def configure_output() -> None: "highlighter": rich.highlighter.NullHighlighter(), } }, - "loggers": { - "twine": { - "handlers": ["console"], - }, + "root": { + "handlers": ["console"], }, } ) From aef83d56939d587414360c1eb5d48ff676d13b7f Mon Sep 17 00:00:00 2001 From: Brian Rutledge Date: Sat, 21 May 2022 08:37:18 -0400 Subject: [PATCH 4/4] Add changelog entry --- changelog/896.bugfix.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog/896.bugfix.rst diff --git a/changelog/896.bugfix.rst b/changelog/896.bugfix.rst new file mode 100644 index 00000000..b03071dc --- /dev/null +++ b/changelog/896.bugfix.rst @@ -0,0 +1 @@ +Reconfgure root logger to show all log messages.