Skip to content

Commit 90681fc

Browse files
committed
Fix zlib-ng generator and MSI paths
1 parent 555d016 commit 90681fc

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

PCbuild/zlib-ng.vcxproj

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,13 +219,15 @@
219219
<PropertyGroup>
220220
<Text>$([System.IO.File]::ReadAllText('$(zlibNgDir)\zlib.h.in').Replace('@ZLIB_SYMBOL_PREFIX@', ''))</Text>
221221
</PropertyGroup>
222-
<WriteLinesToFile File="$(IntDir)zlib.h" Lines="$(Text)" />
222+
<MakeDir Directories="$(GeneratedZlibNgDir)" />
223+
<WriteLinesToFile File="$(GeneratedZlibNgDir)zlib.h" Lines="$(Text)" />
223224
</Target>
224225
<Target Name="_EnsureZlibNgH" Inputs="$(zlibNgDir)\zlib-ng.h.in" Outputs="$(IntDir)zlib-ng.h">
225226
<PropertyGroup>
226227
<Text>$([System.IO.File]::ReadAllText('$(zlibNgDir)\zlib-ng.h.in').Replace('@ZLIB_SYMBOL_PREFIX@', ''))</Text>
227228
</PropertyGroup>
228-
<WriteLinesToFile File="$(IntDir)zlib-ng.h" Lines="$(Text)" />
229+
<MakeDir Directories="$(GeneratedZlibNgDir)" />
230+
<WriteLinesToFile File="$(GeneratedZlibNgDir)zlib-ng.h" Lines="$(Text)" />
229231
</Target>
230232

231233
<Target Name="_EnsureZlibNgHeaders" BeforeTargets="PrepareForBuild"

Tools/msi/freethreaded/freethreaded_files.wxs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,15 @@
6161
<Component Id="freethreaded_python_dll.pdb" Directory="InstallDirectory" Guid="*">
6262
<File Name="python$(var.MajorVersionNumber)$(var.MinorVersionNumber)t.pdb" Source="!(bindpath.build_t)\python$(var.MajorVersionNumber)$(var.MinorVersionNumber)t.pdb" KeyPath="yes" />
6363
</Component>
64+
<!--
65+
Renaming the PDB like this will break automatic connection by debuggers,
66+
but short of making people stop using this installer there's no real option.
67+
-->
6468
<Component Id="freethreaded_python.pdb" Directory="InstallDirectory" Guid="*">
65-
<File Name="python$(var.ShortVersion)t.pdb" Source="!(bindpath.build_t)\python$(var.ShortVersion)t.pdb" />
69+
<File Name="python$(var.ShortVersion)t.pdb" Source="!(bindpath.build_t)\python.pdb" />
6670
</Component>
6771
<Component Id="freethreaded_pythonw.pdb" Directory="InstallDirectory" Guid="*">
68-
<File Name="pythonw$(var.ShortVersion)t.pdb" Source="!(bindpath.build_t)\pythonw$(var.ShortVersion)t.pdb" />
72+
<File Name="pythonw$(var.ShortVersion)t.pdb" Source="!(bindpath.build_t)\pythonw.pdb" />
6973
</Component>
7074
</ComponentGroup>
7175
</Fragment>

0 commit comments

Comments
 (0)