socket.getnameinfo should release the GIL

njsmith · njsmith · commit f4a8cc7559e2 · 2023-05-08T13:45:56.000-07:00
diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
@@ -6883,8 +6883,10 @@ socket_getnameinfo(PyObject *self, PyObject *args)
         }
 #endif
     }
+    Py_BEGIN_ALLOW_THREADS
     error = getnameinfo(res->ai_addr, (socklen_t) res->ai_addrlen,
                     hbuf, sizeof(hbuf), pbuf, sizeof(pbuf), flags);
+    Py_END_ALLOW_THREADS
     if (error) {
         socket_state *state = get_module_state(self);
         set_gaierror(state, error);

Original file line number	Diff line number	Diff line change
`@@ -6883,8 +6883,10 @@ socket_getnameinfo(PyObject self, PyObject args)`
`6883`	`6883`	`}`
`6884`	`6884`	`#endif`
`6885`	`6885`	`}`
	`6886`	`+ Py_BEGIN_ALLOW_THREADS`
`6886`	`6887`	`error = getnameinfo(res->ai_addr, (socklen_t) res->ai_addrlen,`
`6887`	`6888`	`hbuf, sizeof(hbuf), pbuf, sizeof(pbuf), flags);`
	`6889`	`+ Py_END_ALLOW_THREADS`
`6888`	`6890`	`if (error) {`
`6889`	`6891`	`socket_state *state = get_module_state(self);`
`6890`	`6892`	`set_gaierror(state, error);`