Skip to content

gh-91052: Add C API for watching dictionaries #31787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 7, 2022
Merged

gh-91052: Add C API for watching dictionaries #31787

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0447232
gh-91052: Add C API for watching dictionaries
carljm Oct 3, 2022
1c7f814
Add second-watcher tests, fix MSVC warning
carljm Oct 4, 2022
6e5cee2
Over-engineer the watcher bits check
carljm Oct 4, 2022
4bb5d9d
Merge branch 'main' into dictwatch
carljm Oct 5, 2022
7dcf9b0
Address review comments
carljm Oct 6, 2022
7938d6f
Merge branch 'main' into dictwatch
carljm Oct 6, 2022
fb19617
Minor cleanups
carljm Oct 6, 2022
e5d2169
Merge branch 'main' into dictwatch
carljm Oct 6, 2022
cc1d0b7
Address further review comments
carljm Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Over-engineer the watcher bits check
  • Loading branch information
@carljm
carljm committed Oct 4, 2022
commit 6e5cee2a9ef5c6785498dc3dc3f6885d3fd8731f
3 changes: 2 additions & 1 deletion Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5765,11 +5765,12 @@ _PyDict_SendEvent(int watcher_bits,
{
PyInterpreterState *interp = _PyInterpreterState_GET();
for (int i = 0; i < DICT_MAX_WATCHERS; i++) {
if (watcher_bits & (1 << i)) {
if (watcher_bits & 1) {
PyDict_WatchCallback cb = (PyDict_WatchCallback)interp->dict_watchers[i];
if (cb) {
cb(event, (PyObject*)mp, key, value);
}
}
watcher_bits >>= 1;
}
}