Skip to content

Commit cfe14b4

Browse files
sisidovskiChromium LUCI CQ
authored andcommitted
Add UseCounter for registerRouter in InstallEvent
Record UseCounter when InstallEvent.registerRouter is called. This is a requirement to run Origin Trial. UseCounter or UMAs for the router evaluation phase will be added in the next CL. Bug: 1371756 Change-Id: I525edcea06ca9789345a3e78740007c688ff803b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4630653 Reviewed-by: Yoshisato Yanagisawa <[email protected]> Commit-Queue: Shunya Shishido <[email protected]> Cr-Commit-Position: refs/heads/main@{#1160511}
1 parent 825ce8d commit cfe14b4

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3926,6 +3926,7 @@ enum WebFeature {
39263926
kWebGPUQueueSubmit = 4586,
39273927
kWebGPUCanvasContextGetCurrentTexture = 4587,
39283928
kEditContext = 4588,
3929+
kServiceWorkerStaticRouter_RegisterRouter = 4589,
39293930

39303931
// Add new features immediately above this line. Don't change assigned
39313932
// numbers of any item, and don't reuse removed slots.

third_party/blink/renderer/modules/service_worker/install_event.idl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@
1010
constructor(DOMString type, optional ExtendableEventInit eventInitDict = {});
1111
// Experimental
1212
// https://github.com/yoshisatoyanagisawa/service-worker-static-routing-api
13-
[RuntimeEnabled=ServiceWorkerStaticRouter, CallWith=ScriptState] Promise<undefined> registerRouter((RouterRule or sequence<RouterRule>) rules);
13+
[RuntimeEnabled=ServiceWorkerStaticRouter, CallWith=ScriptState, MeasureAs=ServiceWorkerStaticRouter_RegisterRouter] Promise<undefined> registerRouter((RouterRule or sequence<RouterRule>) rules);
1414
};

tools/metrics/histograms/enums.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43370,6 +43370,7 @@ Called by update_use_counter_feature_enum.py.-->
4337043370
<int value="4586" label="WebGPUQueueSubmit"/>
4337143371
<int value="4587" label="WebGPUCanvasContextGetCurrentTexture"/>
4337243372
<int value="4588" label="EditContext"/>
43373+
<int value="4589" label="ServiceWorkerStaticRouter_RegisterRouter"/>
4337343374
</enum>
4337443375

4337543376
<enum name="FeaturePolicyAllowlistType">

0 commit comments

Comments
 (0)