From 89cde1b312e984346ed51e14b44f3a1a9afbb7cb Mon Sep 17 00:00:00 2001 From: Mohamed El Mahallawy Date: Thu, 2 Mar 2017 23:18:59 -0800 Subject: [PATCH 1/2] Fixes #659 Double Click for Word Audio --- src/components/Word/index.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/components/Word/index.js b/src/components/Word/index.js index 348b31441..c330c2842 100644 --- a/src/components/Word/index.js +++ b/src/components/Word/index.js @@ -28,6 +28,13 @@ export default class Word extends React.Component { return title; } + handleWordDoubleClick = () => { + const { word } = this.props; + const audio = new Audio(word.audio.url); // eslint-disable-line + + audio.play(); + } + handleWordClick = () => { const { word, currentVerse, audioActions, audioPosition, isPlaying, isSearched } = this.props; @@ -61,6 +68,7 @@ export default class Word extends React.Component { key={word.code} id={id} onClick={this.handleWordClick} + onDoubleClick={this.handleWordDoubleClick} className={`${className} pointer`} title={this.buildTooltip(word, tooltip)} dangerouslySetInnerHTML={{ __html: word.code }} From 1113245156d7e78c0dfad1cfb76e3e6b5af17d5b Mon Sep 17 00:00:00 2001 From: Mohamed El Mahallawy Date: Sun, 5 Mar 2017 16:00:17 -0800 Subject: [PATCH 2/2] replaced the clicks on word --- src/components/Word/index.js | 8 ++++---- src/types/wordType.js | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/components/Word/index.js b/src/components/Word/index.js index c330c2842..623562529 100644 --- a/src/components/Word/index.js +++ b/src/components/Word/index.js @@ -28,14 +28,14 @@ export default class Word extends React.Component { return title; } - handleWordDoubleClick = () => { + handleWordPlay = () => { const { word } = this.props; const audio = new Audio(word.audio.url); // eslint-disable-line audio.play(); } - handleWordClick = () => { + handleSegmentPlay = () => { const { word, currentVerse, audioActions, audioPosition, isPlaying, isSearched } = this.props; if (isSearched) { @@ -67,8 +67,8 @@ export default class Word extends React.Component { { ...bindTooltip} key={word.code} id={id} - onClick={this.handleWordClick} - onDoubleClick={this.handleWordDoubleClick} + onDoubleClick={this.handleSegmentPlay} + onClick={this.handleWordPlay} className={`${className} pointer`} title={this.buildTooltip(word, tooltip)} dangerouslySetInnerHTML={{ __html: word.code }} diff --git a/src/types/wordType.js b/src/types/wordType.js index af5285254..76e247740 100644 --- a/src/types/wordType.js +++ b/src/types/wordType.js @@ -9,7 +9,6 @@ export default PropTypes.shape({ lineNumber: PropTypes.number.isRequired, pageNumber: PropTypes.number.isRequired, position: PropTypes.number.isRequired, - resourceId: PropTypes.number.isRequired, translation: PropTypes.shape({ languageName: PropTypes.string, text: PropTypes.string