From fb0da492749ef59275bc5daae4a23e9dfc92bd83 Mon Sep 17 00:00:00 2001 From: Naveed Ahmad Date: Sun, 25 Jun 2017 03:41:30 +0500 Subject: [PATCH] Fixed surah dropdown #793 --- src/components/SurahsDropdown/index.js | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/src/components/SurahsDropdown/index.js b/src/components/SurahsDropdown/index.js index 9f3b37d94..0cc05d8ef 100644 --- a/src/components/SurahsDropdown/index.js +++ b/src/components/SurahsDropdown/index.js @@ -9,14 +9,18 @@ const styles = require('./style.scss'); class SurahsDropdown extends Component { shouldComponentUpdate(nextProps) { - return this.props.chapters !== nextProps.chapters; + return this.props.chapter.chapterNumber !== nextProps.chapter.chapterNumber; } renderList() { const { chapters } = this.props; return Object.values(chapters).map((chapter, index) => ( - +
@@ -27,9 +31,13 @@ class SurahsDropdown extends Component {
{chapter.nameSimple}
- {chapter.translatedName.name} + + {chapter.translatedName.name} +
-
+
{chapter.nameArabic}
@@ -46,7 +54,13 @@ class SurahsDropdown extends Component { link className={styles.dropdown} id="chapters-dropdown" - title={chapter.nameSimple || } + title={ + chapter.nameSimple || + + } > {this.renderList()} @@ -56,7 +70,7 @@ class SurahsDropdown extends Component { SurahsDropdown.propTypes = { chapters: customPropTypes.chapters.isRequired, - chapter: customPropTypes.chapters.isRequired, + chapter: customPropTypes.chapters.isRequired }; export default SurahsDropdown;