feat(mainnet): include all benchmarks (#478)

* refactor(benchmakrs): benchmarks mod in its own file (#477)

refactor(benchmark): reorg files

* feat(benchmarks): add every pallet benchmark to mainnet without XCM

* refactor(benchmarks): rename Assets to TrustBackedAssets

* fix(motion): map to Weightless Error one origin check failure

* fix(monetary): Treausyr BenchmarkHelper to use correct ExistentialDeposit

* refactor(mainnet): remove default weights for assets

* refactor(mainnet): remove default weights for pallet_session

* refactor(mainnet): remove default weights from governance modules

* refactor(mainnet): remove default weights from monetary module

* refactor(mainnet): remove default weights from proxy

* refactor(mainnet): remove default weights from revive

* refactor(mainnet): remove default weights from system modules

* refactor(mainnet): remove default weights from utiliy

* feat(mainnet): introduce benchmarks-ci.sh

* refactor(mainnet): remove default weights for pallet_collator_selection

* style(collation): more correct comment.

* refactor(collation): amend candidates_disabled test

* docs(governance): provide docs for CouncilCollective

* docs(benchmakrs): allow missing docs

* chore(benchmarks): update weights results

* refactor(benchmark): rename TrustBackedAssets to Assets

* feat(mainnet): include xcm benchmarks (#479)

* feat(benchmark): add pallet_xcm extrinsic benchmarks

* refactor(benchmkars): amend xcm transfer_assets benchmark

fmt

* style(benchmarks): pretty comments.

* refactor(benchmarks): fund SA of AH on pop in reserve_transfer benchmark

* feat(mainnet): add generic & fungible xcm benchmarks

* refactor(benchmarks): don't define CheckAccount for pallet_xcm_benchmarks::fungible

* refactor(benchmarks): amend benchmarks for pallet_xcm_benchmarks::generic::unsubscribe_version

* feat(mainnet): configure xcm Weigher as WeightInfoBounds

* docs(xcm): missing doc

* refactor(weights): MAX_ASSETS is MaxAssetsIntoHolding

* refactor(mainnet): remove default weights from queue pallets

* docs(xcm): credit source for WeighAssets impl

* docs(xcm): reminders for updating benchmarks

* refactor(mainnet): DeliveryHelper considers delivery to parent

* docs(benchmarks): clarify xcm NonFungible AllOf weight comments

* refactor(api): reorg imports

* style(benchmark): refactor import syntax

* docs(bencmark): better docs for XcmBalances

* refactor(benchmark): define locations via xcm config definitions

* test(xcm): ensure xcm encoding size

* refactor(benchmark): improve worst_case_response

* chore(benchmark): update results for query_response bench

* style(benchmarks): remove RelayAsset

* docs(benchmarks): explain ExistentialDepositAsset

* docs(xcm): note worst_case_holding needs updating

* style(benchmark): better naming

* chore(benchmarks): update xcm benchmarks

visibility

* test(xcm): amend router_uses_ump_for_relay_and_xcmp_for_para

* test(xcm): amend router_uses_ump_for_relay_and_xcmp_for_para

* refactor(benchmarks): unnecessary ParaId::from

* refactor(xcm): unnecessary u64 cast

* test(xcm): msg_length factor is > 1 in price_for_parent_delivery~

* refactor(motion): improve pallet_motion benchmarking

* test(governance): amend simple_majority_is_never_origin

* refactor(weights): move weights into pop_runtime_common

* syle: fmt

* chore(benchmark): improve benchmarking script

* fix(ci): add and properly propagate pop-runtime-common try-runtime feat

Author: al3mart

Cargo.lock

@@ -153,6 +153,7 @@ substrate-frame-rpc-system = { git = "https://github.com/paritytech/polkadot-sdk
 
 # Polkadot
 pallet-xcm = { git = "https://github.com/paritytech/polkadot-sdk", branch = "stable2412", default-features = false }
+pallet-xcm-benchmarks = { git = "https://github.com/paritytech/polkadot-sdk", branch = "stable2412", default-features = false }
 polkadot-cli = { git = "https://github.com/paritytech/polkadot-sdk", branch = "stable2412" }
 polkadot-parachain-primitives = { git = "https://github.com/paritytech/polkadot-sdk", branch = "stable2412", default-features = false }
 polkadot-primitives = { git = "https://github.com/paritytech/polkadot-sdk", branch = "stable2412", default-features = false }

Cargo.toml

@@ -123,6 +123,7 @@ try-runtime = [
 	"pallet-balances/std",
 	"pallet-message-queue/try-runtime",
 	"paseo-runtime?/try-runtime",
+	"pop-runtime-common/try-runtime",
 	"pop-runtime-devnet/try-runtime",
 	"pop-runtime-mainnet/try-runtime",
 	"pop-runtime-testnet/try-runtime",

integration-tests/Cargo.toml

@@ -137,6 +137,7 @@ std = [
 ]
 try-runtime = [
 	"polkadot-cli/try-runtime",
+	"pop-runtime-common/try-runtime",
 	"pop-runtime-devnet/try-runtime",
 	"pop-runtime-mainnet/try-runtime",
 	"pop-runtime-testnet/try-runtime",

node/Cargo.toml

@@ -19,36 +19,42 @@ mod benchmarks {
 	use super::*;
 
 	#[benchmark]
-	fn simple_majority() {
+	fn simple_majority() -> Result<(), BenchmarkError> {
 		let call: <T as Config>::RuntimeCall = frame_system::Call::remark { remark: vec![] }.into();
-		let origin = <T as Config>::SimpleMajorityOrigin::try_successful_origin().unwrap();
+		let origin = <T as Config>::SimpleMajorityOrigin::try_successful_origin()
+			.map_err(|_| BenchmarkError::Stop("Origin should be present"))?;
 
 		#[extrinsic_call]
 		_(origin as T::RuntimeOrigin, Box::new(call));
 
-		assert_last_event::<T>(Event::DispatchSimpleMajority { motion_result: Ok(()) }.into())
+		assert_last_event::<T>(Event::DispatchSimpleMajority { motion_result: Ok(()) }.into());
+		Ok(())
 	}
 
 	#[benchmark]
-	fn super_majority() {
+	fn super_majority() -> Result<(), BenchmarkError> {
 		let call: <T as Config>::RuntimeCall = frame_system::Call::remark { remark: vec![] }.into();
-		let origin = <T as Config>::SuperMajorityOrigin::try_successful_origin().unwrap();
+		let origin = <T as Config>::SuperMajorityOrigin::try_successful_origin()
+			.map_err(|_| BenchmarkError::Stop("Origin should be present"))?;
 
 		#[extrinsic_call]
 		_(origin as T::RuntimeOrigin, Box::new(call));
 
-		assert_last_event::<T>(Event::DispatchSuperMajority { motion_result: Ok(()) }.into())
+		assert_last_event::<T>(Event::DispatchSuperMajority { motion_result: Ok(()) }.into());
+		Ok(())
 	}
 
 	#[benchmark]
-	fn unanimous() {
+	fn unanimous() -> Result<(), BenchmarkError> {
 		let call: <T as Config>::RuntimeCall = frame_system::Call::remark { remark: vec![] }.into();
-		let origin = <T as Config>::UnanimousOrigin::try_successful_origin().unwrap();
+		let origin = <T as Config>::UnanimousOrigin::try_successful_origin()
+			.map_err(|_| BenchmarkError::Stop("Origin should be present"))?;
 
 		#[extrinsic_call]
 		_(origin as T::RuntimeOrigin, Box::new(call));
 
-		assert_last_event::<T>(Event::DispatchUnanimous { motion_result: Ok(()) }.into())
+		assert_last_event::<T>(Event::DispatchUnanimous { motion_result: Ok(()) }.into());
+		Ok(())
 	}
 
 	impl_benchmark_test_suite!(Motion, crate::mock::new_test_ext(), crate::mock::Test);

pallets/motion/src/benchmarking.rs

@@ -17,32 +17,119 @@ docify.workspace = true
 scale-info = { workspace = true, features = [ "derive" ] }
 serde_json = { features = [ "alloc" ], workspace = true }
 
+# Local
+pallet-motion.workspace = true
+
 # Substrate
 frame-support.workspace = true
+frame-system.workspace = true
+pallet-assets.workspace = true
+pallet-aura.workspace = true
+pallet-authorship.workspace = true
+pallet-balances.workspace = true
+pallet-collective.workspace = true
+pallet-message-queue.workspace = true
 pallet-multisig.workspace = true
+pallet-nfts-sdk.workspace = true
+pallet-preimage.workspace = true
+pallet-proxy.workspace = true
+pallet-revive.workspace = true
+pallet-scheduler.workspace = true
+pallet-session.workspace = true
+pallet-sudo.workspace = true
+pallet-timestamp.workspace = true
+pallet-transaction-payment.workspace = true
+pallet-treasury.workspace = true
+pallet-utility.workspace = true
 sp-keyring.workspace = true
 sp-runtime.workspace = true
 
+# Polkadot
+pallet-xcm.workspace = true
+pallet-xcm-benchmarks.workspace = true
+xcm.workspace = true
+xcm-builder.workspace = true
+xcm-executor.workspace = true
+
 # Cumulus
+cumulus-pallet-aura-ext.workspace = true
+cumulus-pallet-parachain-system.workspace = true
+cumulus-pallet-xcmp-queue.workspace = true
+pallet-collator-selection.workspace = true
 parachains-common.workspace = true
 polkadot-parachain-primitives.workspace = true
 polkadot-primitives.workspace = true
 
 [features]
 default = [ "std" ]
 runtime-benchmarks = [
+	"cumulus-pallet-xcmp-queue/runtime-benchmarks",
 	"frame-support/runtime-benchmarks",
+	"frame-system/runtime-benchmarks",
+	"pallet-assets/runtime-benchmarks",
+	"pallet-balances/runtime-benchmarks",
+	"pallet-collator-selection/runtime-benchmarks",
+	"pallet-collective/runtime-benchmarks",
+	"pallet-message-queue/runtime-benchmarks",
+	"pallet-motion/runtime-benchmarks",
+	"pallet-multisig/runtime-benchmarks",
+	"pallet-nfts-sdk/runtime-benchmarks",
+	"pallet-preimage/runtime-benchmarks",
+	"pallet-proxy/runtime-benchmarks",
+	"pallet-revive/runtime-benchmarks",
+	"pallet-scheduler/runtime-benchmarks",
+	"pallet-sudo/runtime-benchmarks",
+	"pallet-timestamp/runtime-benchmarks",
+	"pallet-transaction-payment/runtime-benchmarks",
+	"pallet-treasury/runtime-benchmarks",
+	"pallet-utility/runtime-benchmarks",
+	"pallet-xcm-benchmarks/runtime-benchmarks",
+	"pallet-xcm/runtime-benchmarks",
 	"parachains-common/runtime-benchmarks",
 	"polkadot-primitives/runtime-benchmarks",
 	"sp-runtime/runtime-benchmarks",
+	"xcm-builder/runtime-benchmarks",
+	"xcm-executor/runtime-benchmarks",
 ]
 std = [
 	"codec/std",
+	"cumulus-pallet-aura-ext/std",
+	"cumulus-pallet-xcmp-queue/std",
 	"frame-support/std",
+	"frame-system/std",
+	"pallet-assets/std",
+	"pallet-aura/std",
+	"pallet-authorship/std",
+	"pallet-balances/std",
+	"pallet-collator-selection/std",
+	"pallet-collective/std",
+	"pallet-message-queue/std",
+	"pallet-motion/std",
+	"pallet-multisig/std",
+	"pallet-nfts-sdk/std",
+	"pallet-preimage/std",
+	"pallet-proxy/std",
+	"pallet-revive/std",
+	"pallet-scheduler/std",
+	"pallet-session/std",
+	"pallet-sudo/std",
+	"pallet-timestamp/std",
+	"pallet-transaction-payment/std",
+	"pallet-treasury/std",
+	"pallet-utility/std",
+	"pallet-xcm-benchmarks/std",
+	"pallet-xcm/std",
 	"parachains-common/std",
 	"polkadot-parachain-primitives/std",
 	"polkadot-primitives/std",
 	"scale-info/std",
 	"serde_json/std",
 	"sp-runtime/std",
+	"xcm-builder/std",
+	"xcm-executor/std",
+]
+try-runtime = [
+	"pallet-motion/try-runtime",
+	"pallet-nfts-sdk/try-runtime",
+	"pallet-revive/try-runtime",
 ]

runtime/common/Cargo.toml

@@ -10,6 +10,8 @@ extern crate alloc;
 
 /// Functions used for defining the genesis state of a chain.
 pub mod genesis;
+/// Benchmarked weight functions.
+pub mod weights;
 
 /// Nonce for an account
 pub type Nonce = u32;

runtime/common/src/lib.rs

@@ -15,6 +15,9 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+#![allow(unused_parens)]
+#![allow(unused_imports)]
+#![allow(missing_docs)]
 pub mod constants {
 	use frame_support::{
 		parameter_types,

…ime/mainnet/src/weights/block_weights.rs …time/common/src/weights/block_weights.rsruntime/mainnet/src/weights/block_weights.rs renamed to runtime/common/src/weights/block_weights.rs runtime/mainnet/src/weights/block_weights.rs renamed to runtime/common/src/weights/block_weights.rs

@@ -0,0 +1,57 @@
+
+//! Autogenerated weights for `cumulus_pallet_parachain_system`
+//!
+//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 46.0.0
+//! DATE: 2025-02-28, STEPS: `5`, REPEAT: `5`, LOW RANGE: `[]`, HIGH RANGE: `[]`
+//! WORST CASE MAP SIZE: `1000000`
+//! HOSTNAME: `tux`, CPU: `12th Gen Intel(R) Core(TM) i7-12700H`
+//! WASM-EXECUTION: `Compiled`, CHAIN: `Some("pop")`, DB CACHE: `1024`
+
+// Executed Command:
+// ./target/release//pop-node
+// benchmark
+// pallet
+// --template=./scripts/templates/runtime-weight-template.hbs
+// --chain=pop
+// --wasm-execution=compiled
+// --pallet=cumulus_pallet_parachain_system
+// --extrinsic=*
+// --steps=5
+// --repeat=5
+// --output=./runtime/mainnet/src/weights/
+
+#![cfg_attr(rustfmt, rustfmt_skip)]
+#![allow(unused_parens)]
+#![allow(unused_imports)]
+#![allow(missing_docs)]
+
+use frame_support::{traits::Get, weights::{Weight, constants::RocksDbWeight}};
+use core::marker::PhantomData;
+
+/// Weights for `cumulus_pallet_parachain_system`.
+pub struct WeightInfo<T>(PhantomData<T>);
+impl<T: frame_system::Config> cumulus_pallet_parachain_system::WeightInfo for WeightInfo<T> {
+	/// Storage: `ParachainSystem::LastDmqMqcHead` (r:1 w:1)
+	/// Proof: `ParachainSystem::LastDmqMqcHead` (`max_values`: Some(1), `max_size`: None, mode: `Measured`)
+	/// Storage: `MessageQueue::BookStateFor` (r:1 w:1)
+	/// Proof: `MessageQueue::BookStateFor` (`max_values`: None, `max_size`: Some(52), added: 2527, mode: `MaxEncodedLen`)
+	/// Storage: `MessageQueue::ServiceHead` (r:1 w:1)
+	/// Proof: `MessageQueue::ServiceHead` (`max_values`: Some(1), `max_size`: Some(5), added: 500, mode: `MaxEncodedLen`)
+	/// Storage: `ParachainSystem::ProcessedDownwardMessages` (r:0 w:1)
+	/// Proof: `ParachainSystem::ProcessedDownwardMessages` (`max_values`: Some(1), `max_size`: None, mode: `Measured`)
+	/// Storage: `MessageQueue::Pages` (r:0 w:1000)
+	/// Proof: `MessageQueue::Pages` (`max_values`: None, `max_size`: Some(65585), added: 68060, mode: `MaxEncodedLen`)
+	/// The range of component `n` is `[0, 1000]`.
+	fn enqueue_inbound_downward_messages(n: u32, ) -> Weight {
+		// Proof Size summary in bytes:
+		//  Measured:  `12`
+		//  Estimated: `3517`
+		// Minimum execution time: 2_337_000 picoseconds.
+		Weight::from_parts(2_339_000, 3517)
+			// Standard Error: 1_263_086
+			.saturating_add(Weight::from_parts(179_837_875, 0).saturating_mul(n.into()))
+			.saturating_add(T::DbWeight::get().reads(2_u64))
+			.saturating_add(T::DbWeight::get().writes(2_u64))
+			.saturating_add(T::DbWeight::get().writes((1_u64).saturating_mul(n.into())))
+	}
+}