automargin comment updates

Author: alexcjohnson

src/components/colorbar/draw.js

@@ -549,7 +549,7 @@ module.exports = function draw(gd, id) {
                 marginOpts.b = outerheight * bFrac;
             }
             else {
-                marginOpts.t = marginOpts.b = 0; // TODO - not zero?
+                marginOpts.t = marginOpts.b = 0;
                 marginOpts.yt = opts.y + opts.len * tFrac;
                 marginOpts.yb = opts.y - opts.len * bFrac;
             }

src/components/sliders/draw.js

@@ -42,6 +42,9 @@ module.exports = function draw(gd) {
             delete sliderOpts._commandObserver;
         }
 
+        // Most components don't need to explicitly remove autoMargin, because
+        // marginPushers does this - but slider updates don't go through
+        // a full replot so we need to explicitly remove it.
         Plots.autoMargin(gd, autoMarginId(sliderOpts));
     }
 

src/components/updatemenus/draw.js

@@ -72,7 +72,7 @@ module.exports = function draw(gd) {
         // marginPushers does this - but updatemenu updates don't go through
         // a full replot so we need to explicitly remove it.
         // This is for removing *all* updatemenus, removing individuals is
-        // handled below, in hederGroups.exit
+        // handled below, in headerGroups.exit
         d3.select(this).selectAll('g.' + constants.headerGroupClassName)
             .each(clearAutoMargin);
     }).remove();

src/plot_api/plot_api.js

@@ -361,9 +361,10 @@ exports.plot = function(gd, data, layout, config) {
         initInteractions,
         Plots.addLinks,
         Plots.rehover,
-        // TODO: shouldn't really need doAutoMargin here, but without it some
-        // edits don't manage to tweak the margins the way they should
-        // in the tests, the only one that presently breaks is axis.position
+        // TODO: doAutoMargin is only needed here for axis automargin, which
+        // happens outside of marginPushers where all the other automargins are
+        // calculated. Would be much better to separate margin calculations from
+        // component drawing - see https://github.com/plotly/plotly.js/issues/2704
         Plots.doAutoMargin,
         Plots.previousPromises
     );