feat(proxy): add proxy for auth methods

Author: ralcorta

src/services/afip.service.ts

@@ -1,3 +1,5 @@
+import { resolve } from "path";
+import fs from "fs";
 import { Client } from "soap";
 import { AfipContext } from "../afip-context";
 import { AccessTicket } from "../auth/access-ticket";
@@ -14,6 +16,14 @@ type AfipServiceSoapParam = SoapClientParams & {
   wsdl_test?: WsdlPathEnum;
 } & { serviceName: ServiceNamesEnum };
 
+type SoapServices<T> = Record<
+  "Service",
+  Record<
+    "ServiceSoap" | "ServiceSoap12",
+    Record<keyof T, Record<"input" | "output", Record<string, any>>>
+  >
+>;
+
 export class AfipService<T extends Client> {
   private _soapCliente?: T;
   private _tokens?: WSAuthTokens;
@@ -35,25 +45,50 @@ export class AfipService<T extends Client> {
     }
   }
 
-  public setTokens(tokens: WSAuthTokens): void {
-    this._tokens = tokens;
+  private async proxySoapClient(): Promise<T> {
+    const client = await this.instanceSoapClient();
+    return new Proxy(client, {
+      get: (target: T, prop: string) => {
+        const func = prop.endsWith("Async") ? prop.slice(0, -5) : prop;
+        if (target[func] instanceof Function) {
+          const soapServices: SoapServices<T> = client.describe();
+
+          // Get tokens only if the method exist and require Auth.
+          if (soapServices?.Service?.ServiceSoap?.[func]?.input?.["Auth"]) {
+            return async (req: Record<string, any>) => {
+              return target[prop]({
+                ...(await this.getAuthTokens()),
+                ...req,
+              });
+            };
+          }
+        }
+        return target[prop];
+      },
+    });
   }
 
-  protected async soapClient(): Promise<T> {
-    if (!this._soapCliente) {
-      this._soapCliente = await SoapClientFacade.create<T>({
-        wsdl: this._soapParams.wsdl,
-        options: {
-          disableCache: true,
-          ...this._soapParams.options,
-        },
-      });
-      this._soapCliente.setEndpoint(this._soapParams.url);
-    }
+  private async instanceSoapClient(): Promise<T> {
+    const client = await SoapClientFacade.create<T>({
+      wsdl: this._soapParams.wsdl,
+      options: {
+        disableCache: true,
+        ...this._soapParams.options,
+      },
+    });
+    client.setEndpoint(this._soapParams.url);
+    return client;
+  }
 
+  protected async getClient(): Promise<T> {
+    if (!this._soapCliente) this._soapCliente = await this.proxySoapClient();
     return this._soapCliente;
   }
 
+  public setTokens(tokens: WSAuthTokens): void {
+    this._tokens = tokens;
+  }
+
   /**
    * I generate signatures through the WSAA. If handleTicket is not defined, the function will save the tokens locally.
    * @returns tokens
@@ -82,7 +117,7 @@ export class AfipService<T extends Client> {
    *
    * @param params Parameters to send
    **/
-  protected async getAuthTokens(): Promise<WSAuthParam> {
+  private async getAuthTokens(): Promise<WSAuthParam> {
     if (this._tokens) {
       if (AccessTicket.hasExpired(this._tokens.expirationDate)) {
         if (this.context.handleTicket) {

src/services/electronic-billing.service.ts

@@ -29,7 +29,7 @@ export class ElectronicBillingService extends AfipService<IServiceSoapSoap> {
    * Asks to web service for servers status
    **/
   async getServerStatus(): Promise<IFEDummyOutput> {
-    const client = await this.soapClient();
+    const client = await this.getClient();
     const [output] = await client.FEDummyAsync({});
     return output;
   }
@@ -41,10 +41,8 @@ export class ElectronicBillingService extends AfipService<IServiceSoapSoap> {
    * @return array All sales points availables
    **/
   public async getSalesPoints(): Promise<IGetSalesPointsResult> {
-    const client = await this.soapClient();
-    const [output] = await client.FEParamGetPtosVentaAsync(
-      await this.getAuthTokens()
-    );
+    const client = await this.getClient();
+    const [output] = await client.FEParamGetPtosVentaAsync({});
     return output;
   }
 
@@ -60,10 +58,8 @@ export class ElectronicBillingService extends AfipService<IServiceSoapSoap> {
     salesPoint: number,
     type: number
   ): Promise<IFECompUltimoAutorizadoOutput> {
-    const auth = await this.getAuthTokens();
-    const client = await this.soapClient();
+    const client = await this.getClient();
     const [output] = await client.FECompUltimoAutorizadoAsync({
-      ...auth,
       PtoVta: salesPoint,
       CbteTipo: type,
     });
@@ -79,10 +75,8 @@ export class ElectronicBillingService extends AfipService<IServiceSoapSoap> {
    * @param req data Voucher parameter
    **/
   public async createVoucher(req: IVoucher): Promise<ICreateVoucherResult> {
-    const auth = await this.getAuthTokens();
-    const client = await this.soapClient();
+    const client = await this.getClient();
     const [output] = await client.FECAESolicitarAsync({
-      ...auth,
       FeCAEReq: {
         FeCabReq: {
           CantReg: req.CbteHasta - req.CbteDesde + 1,

src/soap/interfaces/Service/ServiceSoap.ts

@@ -2,7 +2,7 @@ import { Client } from "soap";
 
 /* tslint:disable:max-line-length no-empty-interface */
 export interface IFECAESolicitarInput {
-  Auth: ServiceSoapTypes.IAuth;
+  // Auth: ServiceSoapTypes.IAuth;
   FeCAEReq: ServiceSoapTypes.IFeCAEReq;
 }
 
@@ -153,7 +153,7 @@ export interface IFEParamGetTiposConceptoOutput {
 }
 
 export interface IFEParamGetPtosVentaInput {
-  Auth: ServiceSoapTypes.IAuth;
+  // Auth: ServiceSoapTypes.IAuth;
 }
 
 export interface IFEParamGetPtosVentaOutput {

tests/electronic-billings.service.test.ts

@@ -52,7 +52,7 @@ describe("Electronic Billings Service Test", () => {
         console.dir(voucher, { depth: 50 });
         expect(voucher).not.toBeNull();
       } catch (error) {
-        // console.log(error);
+        console.log(error);
         throw error;
       }
     });