This repository was archived by the owner on Mar 25, 2024. It is now read-only.
Adding e2e Testing #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dramich
reviewed
Jul 15, 2019
dramich
reviewed
Jul 15, 2019
dramich
reviewed
Jul 15, 2019
dramich
reviewed
Jul 15, 2019
dramich
reviewed
Jul 15, 2019
dramich
reviewed
Jul 15, 2019
dramich
reviewed
Jul 15, 2019
Contributor
|
lgtm knowing this won't be ran locally and would require further work later to make that work. #54 |
luthermonson
force-pushed
the
e2e-testing
branch
from
2302beb to
50f9385
Compare
luthermonson
force-pushed
the
e2e-testing
branch
from
50f9385 to
0954d5e
Compare
Contributor
Author
|
closes #38 |
daxmc99
reviewed
Jul 16, 2019
| golangci-lint run | ||
| golangci-lint run --deadline 10m | ||
|
|
||
| echo Running: go fmt |
There was a problem hiding this comment.
Should these be swapped? Run gofmt first since golangci may take much longer?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding e2e testing using k3s to the build process. See ./e2e/README.md for more details on how to run and develop with the e2e tests. Additionally added some bug fixes for cleanup and retries which were found while running these tests.