Skip to content

Commit 253f0cf

Browse files
VladyslavKochetkovzxcpoiu
authored andcommitted
ios: requiresMainQueueSetup / readme: typo
* Fixed typo and grammar * Adds requiresMainQueueSetup Fixed error being throw `"RNInCallManager requires main queue setup since it overrides `init` but doesn't implement `requiresMainQueueSetup`".`
1 parent 9dac19c commit 253f0cf

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

README.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,21 @@ Handling media-routes/sensors/events during a audio/video chat on React Native
1010

1111
The purpose of this module is to handle actions/events during a phone call (audio/video) on `react-native`, ex:
1212

13-
* Manage devices events like wired-headset plugged in state, proximity sensors and expose functionalities to javascript.
13+
* Manage devices events like wired-headset plugged-in state, proximity sensors and expose functionalities to javascript.
1414
* Automatically route audio to proper devices based on events and platform API.
15-
* Toggle speaker or microphone on/off, toggle flash light on/off
15+
* Toggle speaker or microphone on/off, toggle flashlight on/off
1616
* Play ringtone/ringback/dtmftone
1717

18-
Basically, it is a telecommunication module which handles most of requirements when making/receiving/talking with a call.
18+
Basically, it is a telecommunication module which handles most of the requirements when making/receiving/talking with a call.
1919

20-
This module is desinged to work with [react-native-webrtc](https://github.com/oney/react-native-webrtc)
20+
This module is designed to work with [react-native-webrtc](https://github.com/oney/react-native-webrtc)
2121

2222
## TODO / Contribution Wanted:
2323

24-
* Make operations run on main thread. ( iOS/Android )
24+
* Make operations run on the main thread. ( iOS/Android )
2525
* Fix iOS audio shared instance singleton conflict with internal webrtc.
2626
* Detect hardware button press event and react to it.
27-
ex: press bluetooth button, send event to JS to answer/hangup.
27+
ex: press bluetooth button, send an event to JS to answer/hangup.
2828
ex: press power button to mute incoming ringtone.
2929
* Use config-based to decide which event should start and report. maybe control behavior as well.
3030
* Flash API on Android.
@@ -109,7 +109,7 @@ In case `react-native link` doesn't work,
109109
110110
#### Clean project if messed up:
111111
112-
The installation steps are a bit complex, it might related your xcode version, xcode cache, converting swift version, and your own path configurations. if something messed up, please folow steps below to clean this project, then do it again steps by steps.
112+
The installation steps are a bit complex, it might be related your xcode version, xcode cache, converting swift version, and your own path configurations. if something messed up, please follow steps below to clean this project, then do it again steps by steps.
113113
114114
1. Delete all project/directory in xcode related to incall-manager
115115
2. Delete `react-native-incall-manager` in node_modules ( rm -rf )
@@ -260,10 +260,10 @@ Then you can test it on android 6 now.
260260

261261
If you change targetSdkVersion to 23, the `red box` which React Native used to display errors in development mode requires permission `Draw Over Other Apps`.
262262
So in **development mode**, you should manually grant permission in `app settings` on your device or declare `android.permission.SYSTEM_ALERT_WINDOW` in your manifest.
263-
You don't have to do this in **release mode** since there are no red box.
263+
You don't have to do this in **release mode** since there is no red box.
264264

265265

266-
Checkout this awesome project: [react-native-android-permissions](https://github.com/lucasferreira/react-native-android-permissions) by @lucasferreira for more information.
266+
Check out this awesome project: [react-native-android-permissions](https://github.com/lucasferreira/react-native-android-permissions) by @lucasferreira for more information.
267267

268268

269269
## Automatic Basic Behavior:
@@ -272,8 +272,8 @@ Checkout this awesome project: [react-native-android-permissions](https://github
272272
* Store current settings, set KeepScreenOn flag = true, and register some event listeners.
273273
* If media type is `audio`, route voice to earpiece, otherwise route to speaker.
274274
* Audio will enable proximity sensor which is disabled by default if media=video
275-
* When proximity detect user closed to screen, turn off screen to avoid accident touch and route voice to earpiece.
276-
* When newly external device plugged, such as wired-headset, route audio to external device.
275+
* When proximity detects user close to screen, turn off screen to avoid accident touch and route voice to the earpiece.
276+
* When newly external device plugged, such as wired-headset, route audio to an external device.
277277
* Optional play ringback
278278

279279
**On stop:**
@@ -323,7 +323,7 @@ Note: iOS only supports `auto` currently.
323323
| 'onAudioFocusChange' | :smile: | :rage: | see [andriod doc](http://developer.android.com/reference/android/media/AudioManager.OnAudioFocusChangeListener.html#onAudioFocusChange(int)) <br>data: `{'eventText': string, 'eventCode': number }` |
324324

325325
**NOTE: platform OS always has the final decision, so some toggle API may not work in some cases
326-
be carefull when customize your own behavior**
326+
be careful when customizing your own behavior**
327327

328328
## LICENSE:
329329

ios/RNInCallManager/RNInCallManager.m

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,11 @@ @implementation RNInCallManager
6161
NSString *_media;
6262
}
6363

64+
+ (BOOL)requiresMainQueueSetup
65+
{
66+
return NO;
67+
}
68+
6469
RCT_EXPORT_MODULE(InCallManager)
6570

6671
- (instancetype)init

0 commit comments

Comments
 (0)