Skip to content

feat: add React logo and spinners to make init UI nicer #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 15 commits into from
Apr 5, 2019
Merged

feat: add React logo and spinners to make init UI nicer #292

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
090be77
Implement spinners for initializing flow
Esemesek Apr 5, 2019
7bd4bab
Use execa module
Esemesek Apr 5, 2019
8c6895e
Change banner
Esemesek Apr 5, 2019
87ff7fb
Ignore silent flag when in verbose mode
Esemesek Apr 5, 2019
333b371
Refactor packageManager test
Esemesek Apr 5, 2019
1324484
Change loader exports
Esemesek Apr 5, 2019
ce3d2e3
Fix e2e test
Esemesek Apr 5, 2019
45cf422
Rename packageManager
Esemesek Apr 5, 2019
47679a0
Add e2e test
Esemesek Apr 5, 2019
c012f4d
Merge remote-tracking branch 'origin' into init-spinners
Esemesek Apr 5, 2019
5a587d5
smaller paddings for React logo
thymikee Apr 5, 2019
da844c5
Cleanup tests
Esemesek Apr 5, 2019
f544d9d
fix flowfixme
thymikee Apr 5, 2019
8280944
add space for post install script
thymikee Apr 5, 2019
b972cf7
rename packageManager.test as well
thymikee Apr 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup tests
  • Loading branch information
@Esemesek
Esemesek committed Apr 5, 2019
commit da844c58e04a738831ce68eafcb0535371273bbd
14 changes: 0 additions & 14 deletions e2e/__tests__/init.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,17 +84,3 @@ test('init --template file:/tmp/custom/template', () => {

expect(stdout).toContain('Run instructions');
});

test('init --verbose', () => {
const {stdout} = run(DIR, [
'init',
'--template',
'react-native-new-template',
'TestInit',
'--verbose',
]);

expect(stdout).toContain('Initializing new project');
expect(stdout).toContain('No lockfile found');
expect(stdout).toContain('Run instructions');
});
1 change: 1 addition & 0 deletions packages/cli/src/commands/init/__tests__/template.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const TEMPLATE_NAME = 'templateName';

afterEach(() => {
jest.restoreAllMocks();
jest.clearAllMocks();
});

test('installTemplatePackage', async () => {
Expand Down