Fix memory leak on iOS when using controls (AVPlayerViewController)#1647
Merged
CHaNGeTe merged 3 commits intoTheWidlarzGroup:release/4.4.3from Jul 4, 2019
Merged
Fix memory leak on iOS when using controls (AVPlayerViewController)#1647CHaNGeTe merged 3 commits intoTheWidlarzGroup:release/4.4.3from
controls (AVPlayerViewController)#1647CHaNGeTe merged 3 commits intoTheWidlarzGroup:release/4.4.3from
Conversation
ashnfb
approved these changes
Jul 3, 2019
CHaNGeTe
approved these changes
Jul 4, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
controls={true}on iOS we use AVPlayerViewController, but we weren't releasing the AVPlayer instance correctly. This is a simple fix but should lead to much better memory consumption when usingcontrols.Hopefully fixes #113 (and hopefully more related ones)