Link exoplayer with cookies#922
Merged
cobarx merged 4 commits intoTheWidlarzGroup:masterfrom Jun 1, 2018
brandonmoon:link-exoplayer-with-cookies
Merged
Link exoplayer with cookies#922cobarx merged 4 commits intoTheWidlarzGroup:masterfrom brandonmoon:link-exoplayer-with-cookies
cobarx merged 4 commits intoTheWidlarzGroup:masterfrom
brandonmoon:link-exoplayer-with-cookies
Conversation
Contributor
|
@brandonmoon This is a great feature and I'm looking forward to getting it merged. I'd like to test this before merging it, do you by any chance have a server that uses cookie based auth that I can test it against? |
Author
|
@cobarx Thanks! I think I can set you up with something to test with. I'll get back to you in a bit. |
Author
|
OK, here's the test case:
The cookies only last for 15 minutes or so, so you'll need to make sure you make that initial request before playing the video back (it's a rather ugly video of me, sorry!). The bearer token should be valid for 30 days. Let me know if you run into any issues! Also, for convenience: |
Fix spacing
Use the client we create earlier in the function
Contributor
|
Thanks so much for setting that up for me. Everything works great. You've got yourself a merge! |
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, React Native creates a separate instance of OkHttpClient for every module. It does not link up this copy of OkHttpClient to the shared cookies. As a result, video playback fails if it requires cookies for authentication.
I added code to link up the cookies with our instance of OkHttpClient when created in DataSourceUtils.java so that cookie based auth will still work for video playback.