Add react router sample #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinsoftware
force-pushed
the
add-rr-sample
branch
from
0e9f5bf to
b6ff9e4
Compare
Member
Author
|
Fixes #476 |
Daniel15
reviewed
Dec 11, 2017
Member
Daniel15
left a comment
Daniel15
left a comment
There was a problem hiding this comment.
This seems pretty good, I just have some comments inline.
| var executionResult = reactComponent.RenderRouterWithContext(clientOnly, serverOnly); | ||
|
|
||
| if (executionResult.Context?.status != null) | ||
| if (executionResult.Context?.status != null || executionResult.Context?.url != null) |
Member
Author
There was a problem hiding this comment.
It is possible for a redirect to be returned without a status code defined
| public static void ModifyResponse(RoutingContext context, HttpResponse Response) | ||
| { | ||
| var statusCode = context.status.Value; | ||
| var statusCode = context.status ?? 302; |
Member
Author
There was a problem hiding this comment.
If a status code is omitted we can't know if the author intended a permanent or temporary redirect, therefore it's safest to assume temporary
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.