Skip to content

Fix(Tracing): Ensure context is ready before observation creation #3407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hket-tommyluk wants to merge 3 commits into
base: main
Choose a base branch
from
+23 −14
Open

Fix(Tracing): Ensure context is ready before observation creation #3407

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75b5479
Context should be ready before observation be created (#3406)
hket-tommyluk Aug 21, 2025
549b3b4
Allow DefaultLettuceObservationConvention to be extended
hket-tommyluk Aug 21, 2025
93749b1
Keep observation name as lettuce
hket-tommyluk Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Keep observation name as lettuce
  • Loading branch information
@hket-tommyluk
hket-tommyluk committed Aug 22, 2025
commit 93749b15ae15eb91b775129dbbda0b5ac969d2b3
5 changes: 5 additions & 0 deletions src/main/java/io/lettuce/core/tracing/DefaultLettuceObservationConvention.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ public KeyValues getHighCardinalityKeyValues(LettuceObservationContext context)
return KeyValues.empty();
}

@Override
public String getName() {
return "lettuce";
}

@Override
public String getContextualName(LettuceObservationContext context) {
return context.getRequiredCommand().getType().toString().toLowerCase(Locale.ROOT);
Expand Down
5 changes: 0 additions & 5 deletions src/main/java/io/lettuce/core/tracing/RedisObservation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,6 @@ enum RedisObservation implements ObservationDocumentation {
*/
REDIS_COMMAND_OBSERVATION {

@Override
public String getName() {
return "lettuce";
}

@Override
public KeyName[] getLowCardinalityKeyNames() {
return LowCardinalityCommandKeyNames.values();
Expand Down