Skip to content

Commit 5d93514

Browse files
committed
Fix addChildren throws error when ext-grid is hidden
Close mar10#978
1 parent 6b94bb5 commit 5d93514

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

CHANGELOG.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
# BRANCH
2-
* [DEPRECATED] jQuery UI widget methods: use `tree.METHOD()` instead.
3-
* [Fixed] `$.ui.fancytree.getTree()` for Element arg.
4-
51
# 2.34.0-0 / Unreleased
62
* TODO: tree.hasFocus() more reliable.
3+
* [DEPRECATED] jQuery UI widget methods:
4+
Use `tree.METHOD()` instead of `$().fancytree("METHOD")`.
75
* [Added] `tree.debugTime()`, `tree.debugTimeEnd()` for debugging.
8-
* [Added] `tree.destroy()` as shortcut for `tree.widget.destroy()`.
6+
* [Added] `tree.destroy()` as alternative for `tree.widget.destroy()`.
7+
* [Fixed] `$.ui.fancytree.getTree()` for Element arg.
98
* [Fixed] #973 when use ext-grid in one tree, other tree not use ext-grid has error on click.
109
* [Fixed] #974 ext-grid: too much output in production mode.
1110
* [Fixed] #975 ext-grid: fix `tree.visitRows()` for empty tree.
11+
* [Fixed] #978 addChildren throws error when ext-grid is hidden.
1212

1313
# 2.33.0 / 2019-10-29
1414
* [Added] event `preInit` (fired before nodes are loaded).

src/jquery.fancytree.grid.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -281,15 +281,16 @@
281281
// Calculate how many rows fit into current container height
282282
var $table = this.$container,
283283
wrapper = this.scrollWrapper,
284-
trHeight = $table
285-
.find(">tbody>tr")
286-
.first()
287-
.height(),
284+
trHeight =
285+
$table
286+
.find(">tbody>tr")
287+
.first()
288+
.height() || 0,
288289
tableHeight = $table.height(),
289290
headHeight = tableHeight - this.viewport.count * trHeight,
290291
wrapperHeight = wrapper.offsetHeight,
291292
free = wrapperHeight - headHeight,
292-
newCount = Math.floor(free / trHeight);
293+
newCount = Math.floor(free / trHeight) || 0;
293294

294295
// console.info(
295296
// "set container height",
@@ -797,7 +798,7 @@
797798
// node.warn("nodeRender(): ignoring hidden");
798799
return;
799800
}
800-
node.warn("nodeRender(): creating new TR!");
801+
node.debug("nodeRender(): creating new TR.");
801802
node.tr = tree.tbody.rows[node._rowIdx - start];
802803
}
803804
// _assert(

0 commit comments

Comments
 (0)