Skip to content

Commit 7d6e276

Browse files
committed
Cleanup
1 parent 55dfd87 commit 7d6e276

File tree

2 files changed

+17
-19
lines changed

2 files changed

+17
-19
lines changed

demo/sample-ext-table.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ <h1>Example: 'table' extension</h1>
110110
<thead>
111111
<tr> <th></th> <th>#</th> <th></th> <th>Key</th> <th>Like</th> </tr>
112112
</thead>
113-
<!-- Otionally define a row that serves as template, when new nodes are created: -->
113+
<!-- Optionally define a row that serves as template, when new nodes are created: -->
114114
<tbody>
115115
<tr>
116116
<td></td>

src/jquery.fancytree.dnd5.js

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,10 @@
8181
}
8282

8383
/* Convert a dragEnter() or dragOver() response to a canonical form.
84-
* Return false or plain object
85-
* @param {string|object|boolean} r
86-
* @return {object|false}
87-
*/
84+
* Return false or plain object
85+
* @param {string|object|boolean} r
86+
* @return {object|false}
87+
*/
8888
function normalizeDragEnterResponse(r) {
8989
var res;
9090

@@ -178,7 +178,7 @@
178178
}
179179
// Bail out with previous response if we get an invalid dragover
180180
if (!data.node) {
181-
data.tree.warn("Ignore dragover for non-node"); //, event, data);
181+
data.tree.warn("Ignored dragover for non-node"); //, event, data);
182182
return LAST_HIT_MODE;
183183
}
184184

@@ -197,8 +197,7 @@
197197
$targetTitle = $target.find("span.fancytree-title");
198198

199199
if (DRAG_ENTER_RESPONSE === false) {
200-
tree.info("Ignore dragover, since dragenter returned false"); //, event, data);
201-
// $.error("assert failed: dragenter returned false");
200+
tree.debug("Ignored dragover, since dragenter returned false.");
202201
return false;
203202
} else if (typeof DRAG_ENTER_RESPONSE === "string") {
204203
$.error("assert failed: dragenter returned string");
@@ -322,14 +321,14 @@
322321
}
323322

324323
/* Guess dropEffect from modifier keys.
325-
* Safari:
326-
* It seems that `dataTransfer.dropEffect` can only be set on dragStart, and will remain
327-
* even if the cursor changes when [Alt] or [Ctrl] are pressed (?)
328-
* Using rules suggested here:
329-
* https://ux.stackexchange.com/a/83769
330-
* @returns
331-
* 'copy', 'link', 'move', or 'none'
332-
*/
324+
* Safari:
325+
* It seems that `dataTransfer.dropEffect` can only be set on dragStart, and will remain
326+
* even if the cursor changes when [Alt] or [Ctrl] are pressed (?)
327+
* Using rules suggested here:
328+
* https://ux.stackexchange.com/a/83769
329+
* @returns
330+
* 'copy', 'link', 'move', or 'none'
331+
*/
333332
function getDropEffect(event, data) {
334333
var dndOpts = data.options.dnd5,
335334
res = dndOpts.dropEffectDefault;
@@ -431,7 +430,6 @@
431430
) {
432431
// Default processing if any
433432
this._super.apply(this, arguments);
434-
435433
data.node.span.draggable = true;
436434
});
437435
}
@@ -481,7 +479,7 @@
481479
options: tree.options,
482480
originalEvent: event,
483481
dataTransfer: dataTransfer,
484-
// dropEffect: undefined, // set by dragend
482+
// dropEffect: undefined, // set by dragend
485483
isCancelled: undefined, // set by dragend
486484
},
487485
dropEffect = getDropEffect(event, data),
@@ -794,7 +792,7 @@
794792
break;
795793
}
796794
if (!$(node.span).hasClass(classDropOver)) {
797-
node.debug("Ignore dragleave (multi)"); //, event.currentTarget);
795+
node.debug("Ignore dragleave (multi).");
798796
break;
799797
}
800798
$(node.span).removeClass(

0 commit comments

Comments
 (0)