|
81 | 81 | } |
82 | 82 |
|
83 | 83 | /* Convert a dragEnter() or dragOver() response to a canonical form. |
84 | | - * Return false or plain object |
85 | | - * @param {string|object|boolean} r |
86 | | - * @return {object|false} |
87 | | - */ |
| 84 | + * Return false or plain object |
| 85 | + * @param {string|object|boolean} r |
| 86 | + * @return {object|false} |
| 87 | + */ |
88 | 88 | function normalizeDragEnterResponse(r) { |
89 | 89 | var res; |
90 | 90 |
|
|
178 | 178 | } |
179 | 179 | // Bail out with previous response if we get an invalid dragover |
180 | 180 | if (!data.node) { |
181 | | - data.tree.warn("Ignore dragover for non-node"); //, event, data); |
| 181 | + data.tree.warn("Ignored dragover for non-node"); //, event, data); |
182 | 182 | return LAST_HIT_MODE; |
183 | 183 | } |
184 | 184 |
|
|
197 | 197 | $targetTitle = $target.find("span.fancytree-title"); |
198 | 198 |
|
199 | 199 | if (DRAG_ENTER_RESPONSE === false) { |
200 | | - tree.info("Ignore dragover, since dragenter returned false"); //, event, data); |
201 | | - // $.error("assert failed: dragenter returned false"); |
| 200 | + tree.debug("Ignored dragover, since dragenter returned false."); |
202 | 201 | return false; |
203 | 202 | } else if (typeof DRAG_ENTER_RESPONSE === "string") { |
204 | 203 | $.error("assert failed: dragenter returned string"); |
|
322 | 321 | } |
323 | 322 |
|
324 | 323 | /* Guess dropEffect from modifier keys. |
325 | | - * Safari: |
326 | | - * It seems that `dataTransfer.dropEffect` can only be set on dragStart, and will remain |
327 | | - * even if the cursor changes when [Alt] or [Ctrl] are pressed (?) |
328 | | - * Using rules suggested here: |
329 | | - * https://ux.stackexchange.com/a/83769 |
330 | | - * @returns |
331 | | - * 'copy', 'link', 'move', or 'none' |
332 | | - */ |
| 324 | + * Safari: |
| 325 | + * It seems that `dataTransfer.dropEffect` can only be set on dragStart, and will remain |
| 326 | + * even if the cursor changes when [Alt] or [Ctrl] are pressed (?) |
| 327 | + * Using rules suggested here: |
| 328 | + * https://ux.stackexchange.com/a/83769 |
| 329 | + * @returns |
| 330 | + * 'copy', 'link', 'move', or 'none' |
| 331 | + */ |
333 | 332 | function getDropEffect(event, data) { |
334 | 333 | var dndOpts = data.options.dnd5, |
335 | 334 | res = dndOpts.dropEffectDefault; |
|
431 | 430 | ) { |
432 | 431 | // Default processing if any |
433 | 432 | this._super.apply(this, arguments); |
434 | | - |
435 | 433 | data.node.span.draggable = true; |
436 | 434 | }); |
437 | 435 | } |
|
481 | 479 | options: tree.options, |
482 | 480 | originalEvent: event, |
483 | 481 | dataTransfer: dataTransfer, |
484 | | - // dropEffect: undefined, // set by dragend |
| 482 | + // dropEffect: undefined, // set by dragend |
485 | 483 | isCancelled: undefined, // set by dragend |
486 | 484 | }, |
487 | 485 | dropEffect = getDropEffect(event, data), |
|
794 | 792 | break; |
795 | 793 | } |
796 | 794 | if (!$(node.span).hasClass(classDropOver)) { |
797 | | - node.debug("Ignore dragleave (multi)"); //, event.currentTarget); |
| 795 | + node.debug("Ignore dragleave (multi)."); |
798 | 796 | break; |
799 | 797 | } |
800 | 798 | $(node.span).removeClass( |
|
0 commit comments