Skip to content

Commit c038c39

Browse files
committed
ext-column-view: support space and other keys
1 parent 6cb2fe9 commit c038c39

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

CHANGELOG.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
11
# 2.30.1-0 / Unreleased
2-
* Apply and enforce 'prettier' codestyle
2+
* [Changed] Apply and enforce 'prettier' codestyle
3+
* [Changed] #897 Set font for table extension
34
* [Fixed] #894: Fancytree assertion failed: scrollParent should be a simple element or `window`, not document or body.
45
* [Fixed] #896 _requireExtension: order managment
56
* [Fixed] #899 Creating duplicate icon when removing node using extension columnview
67
* [Fixed] #900 ColumnView Extension - Toggle between parent and children not working
7-
* [Changed] #897 Set font for table extension
88

99
# 2.30.0 / 2018-09-02
1010
* [Changed] ext-edit trigger 'clickActive' now only triggers if no modifier keys
1111
(shift, meta, control, ...) are pressed.<br>
1212
Trigger 'shift+click' now only triggers if no other modifier key (control, ...)
1313
is pressed.
14+
* [Changed] #879 Rename ext-debug to ext-logger
15+
(jquery.fancytree.debug.js => jquery.fancytree.logger.js)
1416
* [Added] ext-multi is now deployed with jquery.fancytree-all.js (still experimental)
1517
* [Added] tree.activateKey(key, opts) now has an `opts` argument
1618
* [Added] `nodata` option (bool, string, or callback)
@@ -23,8 +25,6 @@
2325
* [Fixed] #877 postProcess may now also return the object form `{..., children: []}`
2426
* [Fixed] #884 ReferenceError: jQuery is not defined at _simpleDeepMerge
2527
* [Fixed] autoScroll, node.scrollIntoView(), and .makeVisible() now work for tables as well.
26-
* [Changed] #879 Rename ext-debug to ext-logger
27-
(jquery.fancytree.debug.js => jquery.fancytree.logger.js)
2828

2929
# 2.29.1 / 2018-06-27
3030
* [Fixed] #848 Drag End Error with dnd5 extension (again):

src/jquery.fancytree.columnview.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@
108108
// Adjust keyboard behaviour:
109109
.on("fancytreekeydown", function(event, data) {
110110
var next = null,
111+
handled = true,
111112
node = data.node || data.tree.getFirstChild();
112113

113114
if (node.getLevel() >= tree.columnCount) {
@@ -139,11 +140,13 @@
139140
case "up":
140141
next = node.getPrevSibling();
141142
break;
143+
default:
144+
handled = false;
142145
}
143146
if (next) {
144147
next.setActive();
145148
}
146-
return false;
149+
return !handled;
147150
});
148151
},
149152
nodeSetExpanded: function(ctx, flag, callOpts) {

0 commit comments

Comments
 (0)