Skip to content

Commit fae3e90

Browse files
committed
Fix _requireExtension() before argument
Close mar10#896
1 parent a55bb6e commit fae3e90

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# 2.30.1-0 / Unreleased
2-
*
2+
* [FIXED] #896 _requireExtension: order managment
33

44
# 2.30.0 / 2018-09-02
55
* [Changed] ext-edit trigger 'clickActive' now only triggers if no modifier keys

src/jquery.fancytree.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2429,7 +2429,7 @@ Fancytree.prototype = /** @lends Fancytree# */{
24292429
* @param {string} [message] optional error message (defaults to a descriptve error message)
24302430
*/
24312431
_requireExtension: function(name, required, before, message) {
2432-
before = !!before;
2432+
if( before != null ) { before = !!before; }
24332433
var thisName = this._local.name,
24342434
extList = this.options.extensions,
24352435
isBefore = $.inArray(name, extList) < $.inArray(thisName, extList),

test/triage/test-issue-NNN-description.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
<link href="../../src/skin-win8/ui.fancytree.css" rel="stylesheet">
2424
<script src="../../src/jquery-ui-dependencies/jquery.fancytree.ui-deps.js"></script>
2525
<script src="../../src/jquery.fancytree.js"></script>
26+
<script src="../../src/jquery.fancytree.ariagrid.js"></script>
2627
<script src="../../src/jquery.fancytree.childcounter.js"></script>
2728
<script src="../../src/jquery.fancytree.clones.js"></script>
2829
<script src="../../src/jquery.fancytree.columnview.js"></script>
@@ -33,6 +34,8 @@
3334
<script src="../../src/jquery.fancytree.fixed.js"></script>
3435
<script src="../../src/jquery.fancytree.glyph.js"></script>
3536
<script src="../../src/jquery.fancytree.gridnav.js"></script>
37+
<script src="../../src/jquery.fancytree.logger.js"></script>
38+
<script src="../../src/jquery.fancytree.multi.js"></script>
3639
<script src="../../src/jquery.fancytree.persist.js"></script>
3740
<script src="../../src/jquery.fancytree.table.js"></script>
3841
<script src="../../src/jquery.fancytree.themeroller.js"></script>

test/triage/test-issue-NNN-table-description.html

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,20 @@
2323
<link href="../../src/skin-win8/ui.fancytree.css" rel="stylesheet">
2424
<script src="../../src/jquery-ui-dependencies/jquery.fancytree.ui-deps.js"></script>
2525
<script src="../../src/jquery.fancytree.js"></script>
26+
<script src="../../src/jquery.fancytree.ariagrid.js"></script>
2627
<script src="../../src/jquery.fancytree.childcounter.js"></script>
2728
<script src="../../src/jquery.fancytree.clones.js"></script>
2829
<script src="../../src/jquery.fancytree.columnview.js"></script>
2930
<script src="../../src/jquery.fancytree.dnd.js"></script>
3031
<script src="../../src/jquery.fancytree.dnd5.js"></script>
3132
<script src="../../src/jquery.fancytree.edit.js"></script>
3233
<script src="../../src/jquery.fancytree.filter.js"></script>
34+
<script src="../../src/jquery.fancytree.fixed.js"></script>
3335
<script src="../../src/jquery.fancytree.glyph.js"></script>
34-
<script src="../../src/jquery.fancytree.persist.js"></script>
3536
<script src="../../src/jquery.fancytree.gridnav.js"></script>
37+
<script src="../../src/jquery.fancytree.logger.js"></script>
38+
<script src="../../src/jquery.fancytree.multi.js"></script>
39+
<script src="../../src/jquery.fancytree.persist.js"></script>
3640
<script src="../../src/jquery.fancytree.table.js"></script>
3741
<script src="../../src/jquery.fancytree.themeroller.js"></script>
3842
<script src="../../src/jquery.fancytree.wide.js"></script>

0 commit comments

Comments
 (0)