fix: absent day & lwp caluclation based on half day, assert test cases based on updated conditions

(cherry picked from commit da6ee48)

Author: iamkhanraheel

hrms/payroll/doctype/salary_slip/salary_slip.py

@@ -507,7 +507,8 @@ def get_working_days_details(self, lwp=None, for_preview=0):
 					consider_marked_attendance_on_holidays,
 					holidays,
 				)
-				self.payment_days -= (half_absent_days * daily_wages_fraction_for_half_day)
+				self.absent_days += half_absent_days * daily_wages_fraction_for_half_day
+				self.payment_days -= half_absent_days * daily_wages_fraction_for_half_day
 		else:
 			self.payment_days = 0
 
@@ -542,11 +543,7 @@ def get_half_absent_days(
 				& (Attendance.half_day_status == "Absent")
 			)
 		)
-		if (
-			(not include_holidays_in_total_working_days)
-			and (not consider_marked_attendance_on_holidays)
-			and holidays
-		):
+		if (not consider_marked_attendance_on_holidays) and holidays:
 			query = query.where(Attendance.attendance_date.notin(holidays))
 		return query.run()[0][0]
 
@@ -746,7 +743,7 @@ def calculate_lwp_ppl_and_absent_days_based_on_attendance(
 				]
 
 			if d.status == "Half Day" and d.leave_type and d.leave_type in leave_type_map.keys():
-				equivalent_lwp = 1 - daily_wages_fraction_for_half_day
+				equivalent_lwp = 1 - daily_wages_fraction_for_half_day if d.half_day_status == "Absent" else 1
 
 				if leave_type_map[d.leave_type]["is_ppl"]:
 					equivalent_lwp *= (

hrms/payroll/doctype/salary_slip/test_salary_slip.py

@@ -297,9 +297,10 @@ def test_payment_days_considering_half_days_unmarked_as_present(self):
 		# from half lwp
 		self.assertEqual(ss.leave_without_pay, 0.5)
 
-		self.assertEqual(ss.absent_days, 1)
+		self.assertEqual(ss.absent_days, 2.5)
 
-		self.assertEqual(ss.payment_days, days_in_month - no_of_holidays - 1.5)
+		# total payment days = total working days - lwp - absent days
+		self.assertEqual(ss.payment_days, days_in_month - no_of_holidays - 0.5 - 2.5)
 
 		# Gross pay calculation based on attendances
 		gross_pay = 78000 - (
@@ -779,7 +780,6 @@ def test_consider_marked_attendance_on_holidays_with_half_day_on_holiday(self):
 			emp_id,
 			first_sunday,
 			"Half Day",
-			leave_type="Leave Without Pay",
 			half_day_status="Absent",
 			ignore_validate=True,
 		)