Skip to content

Commit 9aa5371

Browse files
fix(ui): update About dialog with contributor credits and green icon (#240)
* fix(ui): update About dialog with contributor credits and green icon Replace "Contributions welcome" with linked contributor names (validatedev, davidarny) and swap the outdated blue icon asset for the current green app icon. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(ui): rename About dialog contributors label to maintainers Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 903e6b2 commit 9aa5371

3 files changed

Lines changed: 24 additions & 2 deletions

File tree

public/icon.png

-170 KB
Loading

src/components/about-dialog.test.tsx

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,24 @@ vi.mock("@tauri-apps/plugin-opener", () => ({
1313
}))
1414

1515
describe("AboutDialog", () => {
16-
it("renders version and links", () => {
16+
it("renders version, links, and maintainers", () => {
1717
render(<AboutDialog version="1.2.3" onClose={() => {}} />)
1818
expect(screen.getByText("OpenUsage")).toBeInTheDocument()
1919
expect(screen.getByText("v1.2.3")).toBeInTheDocument()
2020
expect(screen.getByText("GitHub")).toBeInTheDocument()
21+
expect(screen.getByRole("button", { name: "validatedev" })).toBeInTheDocument()
22+
expect(screen.getByRole("button", { name: "davidarny" })).toBeInTheDocument()
23+
})
24+
25+
it("opens maintainer GitHub profiles on click", async () => {
26+
render(<AboutDialog version="1.2.3" onClose={() => {}} />)
27+
28+
await userEvent.click(screen.getByRole("button", { name: "validatedev" }))
29+
expect(openerState.openUrlMock).toHaveBeenCalledWith("https://github.com/validatedev")
30+
31+
openerState.openUrlMock.mockClear()
32+
await userEvent.click(screen.getByRole("button", { name: "davidarny" }))
33+
expect(openerState.openUrlMock).toHaveBeenCalledWith("https://github.com/davidarny")
2134
})
2235

2336
it("closes on Escape", async () => {

src/components/about-dialog.tsx

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,16 @@ export function AboutDialog({ version, onClose }: AboutDialogProps) {
8888
GitHub
8989
</ExternalLink>
9090
</p>
91-
<p className="text-xs pt-1">Contributions welcome</p>
91+
<p className="text-xs pt-1">
92+
Maintainers:{" "}
93+
<ExternalLink href="https://github.com/validatedev">
94+
validatedev
95+
</ExternalLink>
96+
,{" "}
97+
<ExternalLink href="https://github.com/davidarny">
98+
davidarny
99+
</ExternalLink>
100+
</p>
92101
</div>
93102
</div>
94103
</div>

0 commit comments

Comments
 (0)