Merge pull request REMitchell#53 from yangadam/master

Fix code issues, add .gitignore and remove files that should be ignored

Author: REMitchell

.gitignore

@@ -0,0 +1,106 @@
+# Byte-compiled / optimized / DLL files
+__pycache__/
+*.py[cod]
+*$py.class
+
+# C extensions
+*.so
+
+# Distribution / packaging
+.Python
+build/
+develop-eggs/
+dist/
+downloads/
+eggs/
+.eggs/
+lib/
+lib64/
+parts/
+sdist/
+var/
+wheels/
+*.egg-info/
+.installed.cfg
+*.egg
+MANIFEST
+
+# PyInstaller
+#  Usually these files are written by a python script from a template
+#  before PyInstaller builds the exe, so as to inject date/other infos into it.
+*.manifest
+*.spec
+
+# Installer logs
+pip-log.txt
+pip-delete-this-directory.txt
+
+# Unit test / coverage reports
+htmlcov/
+.tox/
+.coverage
+.coverage.*
+.cache
+nosetests.xml
+coverage.xml
+*.cover
+.hypothesis/
+
+# Translations
+*.mo
+*.pot
+
+# Django stuff:
+*.log
+.static_storage/
+.media/
+local_settings.py
+
+# Flask stuff:
+instance/
+.webassets-cache
+
+# Scrapy stuff:
+.scrapy
+
+# Sphinx documentation
+docs/_build/
+
+# PyBuilder
+target/
+
+# Jupyter Notebook
+.ipynb_checkpoints
+
+# pyenv
+.python-version
+
+# celery beat schedule file
+celerybeat-schedule
+
+# SageMath parsed files
+*.sage.py
+
+# Environments
+.env
+.venv
+env/
+venv/
+ENV/
+env.bak/
+venv.bak/
+
+# Spyder project settings
+.spyderproject
+.spyproject
+
+# Rope project settings
+.ropeproject
+
+# mkdocs documentation
+/site
+
+# mypy
+.mypy_cache/
+
+.DS_Store

chapter1/.DS_Store

@@ -2,5 +2,5 @@
 from bs4 import BeautifulSoup
 
 html = urlopen("http://www.pythonscraping.com/exercises/exercise1.html")
-bsObj = BeautifulSoup(html.read())
+bsObj = BeautifulSoup(html, "html.parser")
 print(bsObj.h1)

chapter1/2-beautifulSoup.py

@@ -11,7 +11,7 @@ def getTitle(url):
         print(e)
         return None
     try:
-        bsObj = BeautifulSoup(html.read())
+        bsObj = BeautifulSoup(html, "html.parser")
         title = bsObj.body.h1
     except AttributeError as e:
         return None

chapter1/3-exceptionHandling.py

@@ -1,3 +1,4 @@
+from selenium import webdriver
 from selenium.webdriver.common.by import By
 from selenium.webdriver.support.ui import WebDriverWait
 from selenium.webdriver.support import expected_conditions as EC

chapter10/2-waitForLoad.py

@@ -18,9 +18,9 @@ def test_PageProperties(self):
         url = "http://en.wikipedia.org/wiki/Monty_Python"
         #Test the first 100 pages we encounter
         for i in range(1, 100):
-            bsObj = BeautifulSoup(urlopen(url))
+            bsObj = BeautifulSoup(urlopen(url), 'html.parser')
             titles = self.titleMatchesURL()
-            self.assertEquals(titles[0], titles[1])
+            self.assertEqual(titles[0], titles[1])
             self.assertTrue(self.contentExists())
             url = self.getNextLink()
         print("Done!")

chapter11/ghostdriver.log

@@ -4,5 +4,5 @@
 driver = webdriver.PhantomJS(executable_path='/Users/ryan/Documents/pythonscraping/code/headless/phantomjs-1.9.8-macosx/bin/phantomjs')
 driver.get("http://en.wikipedia.org/wiki/Monty_Python")
 assert "Monty Python" in driver.title
-print("Monty Python was not in the title")
+print("Monty Python was in the title")
 driver.close()