[cxxmodules] Fix absolute paths for v7 headers in modulemap

Our CMake code for making path to headers relative is broken
for the v7 headers (as they don't have the 'CURRENT_SOURCE/inc'
prefix we check for). This caused that we have absolute paths for
those headers in the modulemap we ship with ROOT. As the paths
are only valid on the same system in the specific build folder,
they prevent anyone from successfully building any ROOT module
with this modulemap.

This patch adds the additional check for v7 headers and also
adds a fallback where we always remove the current source dir
from the paths (which is necessary for all the tests which
don't follow any directory structure).

Also adds a sanity check that should prevent this error in the
future by checking that paths are not absolute before we write
them to the modulemap.

Author: Teemperor

cmake/modules/RootNewMacros.cmake

@@ -262,6 +262,8 @@ function(ROOT_GENERATE_DICTIONARY dictionary)
     endif()
   endforeach()
   string(REPLACE "${CMAKE_CURRENT_SOURCE_DIR}/inc/" ""  headerfiles "${headerfiles}")
+  string(REPLACE "${CMAKE_CURRENT_SOURCE_DIR}/v7/inc/" ""  headerfiles "${headerfiles}")
+
   # Replace the non-standard folder layout of Core.
   if (ARG_STAGE1 AND ARG_MODULE STREQUAL "Core")
     # FIXME: Glob these folders.
@@ -273,6 +275,22 @@ function(ROOT_GENERATE_DICTIONARY dictionary)
     endforeach()
   endif()
 
+  # Check that each path here is relative so that it no longer points to the build folder.
+  # If we don't do this, then for example the modulemap might contain absolute paths to the
+  # build folder which would break module compilation.
+  if(PROJECT_NAME STREQUAL ROOT)
+    foreach(hf ${headerfiles})
+      string(REPLACE "${PROJECT_SOURCE_DIR}" "" hfrel "${hf}")
+      # Test folders don't follow this pattern and need absolute paths,
+      # so we don't run our sanity check on them.
+      if(NOT "${hfrel}" MATCHES "/test/")
+        if(IS_ABSOLUTE "${hf}")
+          message(SEND_ERROR "Header path '${hf}' ${hfrel} is not relative!")
+        endif()
+      endif()
+    endforeach()
+  endif()
+
   if(CMAKE_PROJECT_NAME STREQUAL ROOT)
     set(includedirs -I${CMAKE_SOURCE_DIR}
                     -I${CMAKE_SOURCE_DIR}/interpreter/cling/include # This is for the RuntimeUniverse