Skip to content

Commit 31abd68

Browse files
committed
Update changelog and minor whitespace changes
1 parent 0616808 commit 31abd68

File tree

3 files changed

+20
-15
lines changed

3 files changed

+20
-15
lines changed

changelog.org

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -308,6 +308,9 @@
308308
* Work log
309309
Log of merges/issues/work that's gone in so I know what to put in
310310
the changelog for the next release
311+
** 2013-07-18
312+
- merged https://github.com/dakrone/clj-http/pull/146 to correctly
313+
reference parameter names
311314
** Released 0.7.5
312315
** 2013-07-10
313316
- Only redirect if a "location" header is actually, present, avoiding an

src/clj_http/core.clj

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,8 @@
131131
k (cond
132132
(and (not= ClientPNames/CONN_MANAGER_TIMEOUT k)
133133
(instance? Long v))
134-
(Integer. ^Long v)
135-
true v)))))
134+
(Integer. ^Long v)
135+
true v)))))
136136

137137

138138
(defn- coerce-body-entity
@@ -224,12 +224,13 @@
224224
(proxy [HttpRequestRetryHandler] []
225225
(retryRequest [e cnt context]
226226
(retry-handler e cnt context)))))
227-
(add-client-params! http-client
228-
;; merge in map of specified timeouts, to
229-
;; support backward compatiblity.
230-
(merge {CoreConnectionPNames/SO_TIMEOUT socket-timeout
231-
CoreConnectionPNames/CONNECTION_TIMEOUT conn-timeout}
232-
client-params))
227+
(add-client-params!
228+
http-client
229+
;; merge in map of specified timeouts, to
230+
;; support backward compatiblity.
231+
(merge {CoreConnectionPNames/SO_TIMEOUT socket-timeout
232+
CoreConnectionPNames/CONNECTION_TIMEOUT conn-timeout}
233+
client-params))
233234

234235
(when-let [[user pass] digest-auth]
235236
(.setCredentials

test/clj_http/test/core.clj

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -438,13 +438,14 @@
438438

439439
;; Regression, get notified if something changes
440440
(deftest ^{:integration true} t-known-client-params-are-unchanged
441-
(let [params [
442-
"http.socket.timeout" CoreConnectionPNames/SO_TIMEOUT
443-
"http.connection.timeout" CoreConnectionPNames/CONNECTION_TIMEOUT
444-
"http.protocol.version" CoreProtocolPNames/PROTOCOL_VERSION
445-
"http.useragent" CoreProtocolPNames/USER_AGENT
446-
"http.conn-manager.timeout" ClientPNames/CONN_MANAGER_TIMEOUT
447-
"http.protocol.allow-circular-redirects" ClientPNames/ALLOW_CIRCULAR_REDIRECTS]]
441+
(let [params ["http.socket.timeout" CoreConnectionPNames/SO_TIMEOUT
442+
"http.connection.timeout"
443+
CoreConnectionPNames/CONNECTION_TIMEOUT
444+
"http.protocol.version" CoreProtocolPNames/PROTOCOL_VERSION
445+
"http.useragent" CoreProtocolPNames/USER_AGENT
446+
"http.conn-manager.timeout" ClientPNames/CONN_MANAGER_TIMEOUT
447+
"http.protocol.allow-circular-redirects"
448+
ClientPNames/ALLOW_CIRCULAR_REDIRECTS]]
448449
(doseq [[plaintext constant] (partition 2 params)]
449450
(is (= plaintext constant)))))
450451

0 commit comments

Comments
 (0)